Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: Improve scroll view handling when expanding #23327

Merged
merged 34 commits into from
Jul 14, 2020
Merged

Panel: Improve scroll view handling when expanding #23327

merged 34 commits into from
Jul 14, 2020

Commits on Jun 19, 2020

  1. Add scrollIntoView interaction for PanelBody 

    Refactor interactions with Reakit/Disclosure.
Add custom hooks for ref and rendering handling.
    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    cb813a1 View commit details
    Browse the repository at this point in the history

  2. Adjust PanelBody story to include scrollIntoView example

    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    5cddfb0 View commit details
    Browse the repository at this point in the history

  3. Adjust bottom padding for Layout sidebar

    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7311fb7 View commit details
    Browse the repository at this point in the history

  4. Allow for opened prop to control disclosure state

    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7619ffd View commit details
    Browse the repository at this point in the history

  5. Update PanelBody tests

    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    546a846 View commit details
    Browse the repository at this point in the history

  6. Update snapshots

    Jon Q committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ff1c7cf View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1f183ac View commit details
    Browse the repository at this point in the history

  2. Fix tests for PanelColorSettings + Update snapshots

    Jon Q committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    fa31367 View commit details
    Browse the repository at this point in the history

  3. Add new PanelBody props to README

    Jon Q committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d1fed38 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3c8326c View commit details
    Browse the repository at this point in the history

  2. Add react-merge-refs dependency

    Jon Q committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    29a4949 View commit details
    Browse the repository at this point in the history

  3. Use react-merge-refs util

    Jon Q committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    5e82406 View commit details
    Browse the repository at this point in the history

  4. Update test snapshots

    Jon Q committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    db594d7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    740f69e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    ff7b3a6 View commit details
    Browse the repository at this point in the history

  2. Remove disableSmoothScrollIntoView prop from PanelBody

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    277f242 View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    85d4384 View commit details
    Browse the repository at this point in the history

  4. Remove focusable prop

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    09776c1 View commit details
    Browse the repository at this point in the history

  5. Remove use-combined-refs - No longer needed

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    1425782 View commit details
    Browse the repository at this point in the history

  6. Remove onToggle from useUpdateEffect deps array

    Jon Q committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    73783b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e61bb11 View commit details
    Browse the repository at this point in the history

  2. Adjust onToggle callback handling

    Jon Q committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    444bc3a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a2dfe87 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    8c4f6a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    a194641 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    2e5b430 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1c1ff72 View commit details
    Browse the repository at this point in the history

  2. Remove Reakit/Disclosure integration (for now)

    Jon Q committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fb33dc0 View commit details
    Browse the repository at this point in the history

  3. Update PanelBody tests

    Jon Q committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    c50d006 View commit details
    Browse the repository at this point in the history

  4. Update snapshots

    Jon Q committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    10fdadc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fe70a9a View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Merge branch 'master' into update/panel-improve-scroll-view-handling

    Jon Q committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d7c22a0 View commit details
    Browse the repository at this point in the history

  2. Fix initialOpen handling for PanelBody

    Jon Q committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    45510e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Remove unnecessary act wrappers in panel body tests

    Jon Q committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    8a35791 View commit details
    Browse the repository at this point in the history