Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Fix handling of child blocks #23231

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Inserter: Fix handling of child blocks #23231

merged 4 commits into from
Jun 18, 2020

Commits on Jun 18, 2020

  1. Inserter: Fix handling of child blocks 

    When a block C specifies `parent: [ P ]`, it means that C may only be
added to P. It does NOT mean that P may *only* contain C. (Which is what
`<InnerBlocks allowedBlocks={ [ C ] }>` means.)

This fixes the Inserter so that the correct blocks are shown when
inserting into a block that is referenced by `parent`. It does so by
leaning on `getInserterItems()` which does the right thing.
    @noisysocks
    noisysocks committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ea1c443 View commit details
    Browse the repository at this point in the history

  2. Inserter: Make ChildBlocks have a similar API to InserterPanel

    @noisysocks
    noisysocks committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    436d7c0 View commit details
    Browse the repository at this point in the history

  3. E2E Tests: Add Child Blocks tests and test plugin

    @noisysocks
    noisysocks committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3bb29ad View commit details
    Browse the repository at this point in the history

  4. Inserter: Clarify inline comment

    @noisysocks
    noisysocks committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8b5ca5a View commit details
    Browse the repository at this point in the history