Block Directory: Add list of installed blocks to pre-publish sidebar #22752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Block Directory
|
Size Change: +480 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
Nice! Good call pulling these changes out into a new branch. Personally, i'm not certain I understand the risk of not having a persistence mechanism in place. I'm tempted to say that it provides value as is but it may make sense to get more input for others before merge. Code wise 👍. |
StevenDufresne
approved these changes
Jun 1, 2020
There's no risk here, now— but it's tied into how the uninstalling unused blocks process will work. This is just to get some UI in place so it's easier to iterate on later. |
Yep. I'm good with merging it. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulls out some code from #22452, to display the list of installed blocks in the pre-publish sidebar. This only shows blocks that have been installed in this editing session, regardless of whether they're still in use — determining unused blocks & uninstallation is another issue (#22307). The intent here is to get the UI in place.
How has this been tested?
Search for and install some blocks on an unpublished post, then click publish. There should now be a panel at the bottom showing the blocks you've added. This is only pulling from the installed blocks state, so if you reload the page, you won't see any previously-installed blocks. Persisting installed blocks might be handled with the new block type API, see #22307.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: