-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation block] Display appender only in currently active menu #22311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Block] Navigation
Affects the Navigation Block
labels
May 13, 2020
adamziel
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
May 13, 2020 08:34
6 tasks
Size Change: +159 B (0%) Total Size: 828 kB
ℹ️ View Unchanged
|
Some test cases are failing, I may need to update them |
karmatosed
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving design wise - I know tests are failing so need sorting.
It seems like test failures were only temporary - restarting Travis helped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code is already tested and accepted in #22165. It's just it was merged into try/sub-nav-editing instead of master. See the original description below:
This is a follow-up on #22107 to remove the appender from non-active navigation blocks:
I extracted this into a separate PR because it broke multiple tests and I didn't want it to block the other changes.
How has this been tested?
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist: