Adds a default text label to the block appender when it can only insert a single block type #22293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +289 kB (25%) 🚨 Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
There's a visual bug when the submenu is too narrow:
Perhaps we should say just "Add a link"? |
adamziel
reviewed
May 15, 2020
packages/block-editor/src/components/button-block-appender/index.js
Outdated
Show resolved
Hide resolved
adamziel
approved these changes
May 15, 2020
|
One note, if we're going to have this here I think it's important to say 'add link' not the longer text. Can we get an interaction with that, please? |
|
I am not sure about this thing. @mtias the original implementation of "if there is a single block type that can be appended, append that directly" added a tooltip that reads "Add blockname". Do we want custom shorter text for the navigation block, because the block name of the Navigation Link block is Navigation Link :) |
|
@draganescu for me the 'add' type is link though, I don't think it needs the navigation declaration. |
|
It should have the full block name. If we want to trim it down then we should trim down the block name itself. |
mtias
reviewed
May 21, 2020
packages/block-editor/src/components/button-block-appender/style.scss
Outdated
Show resolved
Hide resolved
mtias
reviewed
May 21, 2020
packages/block-editor/src/components/button-block-appender/index.js
Outdated
Show resolved
Hide resolved
also refactores out useless component
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20728
Adds a default text label to the block appender when it can only insert a single block type.
How has this been tested?
Tested locally by:
a) for the Navigation / Buttons block when selected the appender shows when the block is selected
b) for the Navigation / Buttons block when selected the appender has a label specifying the kind of block to add when the parent block is selected
c) for the columns block the default appender (after inserting a paragraph) does not show a label, but does show a tooltip with the text "Add block"
Screenshots
Types of changes
Non breaking change that reuses the text for the existing tool tip of the appender to show a default label next to the icon.
Issues
As can be seen in the GIF above, there are a few issues:
A separate issue is that is appears that blocks don't use the same appender. E.g. the social icons block does not show the "Add block" tooltip as you'd expect. neither is shows another tooltip at all, which means it uses a custom appender.