Fix flaky test in rich text.

[sainthkh]

• Closes Flaky test in rich-text e2e test. #22201

Description

It seems that there's a racing condition between:

• loading a new rich text editor.
• pressing ctrl + b

I've resolved this by waiting for loading a new rich text editor.

How has this been tested?

Manually running it.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• [N/A] My code follows the accessibility standards.
• [N/A] My code has proper inline documentation.
• [N/A] I've included developer documentation if appropriate.
• [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

[gziolo]

It looks like an improvement 👍

[aduth]

While this can work, and waitForSelector is often an inevitable choice, I think it's worth noting that waitForSelector could actually imply the user has to physically sit and wait before they can proceed. And at least in these sorts of text-writing workflows, we shouldn't ever expect a user to have to wait between pressing Enter to create a new paragraph, then proceeding to type in that paragraph.

[aduth]

Also, heads-up that if you want, as a Member, you should be able to create branches directly from the Gutenberg source repository, rather than working from your fork.

[aduth]

Related Slack discussion (link requires registration):

https://wordpress.slack.com/archives/C5UNMSU4R/p1588940894045800

[sainthkh]

I guess it's simply a few millisecond difference. It usually doesn't matter to human because they're not that fast enough.

But I agree it can cause confusion. It can mean users should wait for a few seconds. I used it because waitFor is not allowed by eslint . Maybe waitFor(10) and eslint-disable might be the better choice.