Preview Button: Save post before navigating to preview #2193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1295
This pull request seeks to address the need for a post autosave to occur before showing a preview, as otherwise the preview will not reflect unsaved changes applied to the post.
Implementation notes:
Because popup windows can only be opened in response to user interaction, the solution here is:
about:blank
as soon as user clicks button, retaining reference to popup windowTesting instructions:
Verify that any unsaved changes are reflected in preview.
Ensure unit tests pass:
Caveats:
Published post autosave is not yet implemented. See #1773 (comment).