Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload multiple files by dropping on image placeholder #21807

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sainthkh
Copy link
Contributor

Description

You can upload multiple images by dropping them on image placeholder.

How has this been tested?

I manually tested it and I'm trying to find ways to write automated code. But it's hard to find good example for drag and drop.

Screenshots

multiple-images

Types of changes

New feature.

Checklist:

  • [??] My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • My code has proper inline documentation.
  • [N/A] I've included developer documentation if appropriate.
  • [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 10, 2021

Hi @sainthkh

How can we help?

Base automatically changed from master to trunk March 1, 2021 15:43
@draganescu
Copy link
Contributor

Howdy @sainthkh! Thanks for the work here. Could you bring this PR up to date with trunk so testing becomes easier? Thank you 👏🏻

@paaljoachim
Copy link
Contributor

I believe that @Mamaduka George has earlier worked on something similar to this.
George perhaps you can take a look when you have the chance?

@paaljoachim
Copy link
Contributor

Actually this might be something for @glendaviesnz to check out after the Refactored Gallery plugin has been added to the Gutenberg plugin. As uploading multiple images one should have the option to either create a gallery or upload as individual images.

@glendaviesnz
Copy link
Contributor

As uploading multiple images one should have the option to either create a gallery or upload as individual images.

I am not sure how the UI would look for this, but it would help reduce any confusion if the user got some sort of prompt to select individual images or a gallery when dropping multiple image files. Could be worth adding a issue for this as you note to follow up after the gallery refactor is merged.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jul 11, 2021

Hey Glen @glendaviesnz
I made a new issue that we can add to the Gallery project board.
#33348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Package] Block library /packages/block-library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images: Support for drag-and-drop multiple images onto image block
4 participants