Fix: Visual issue on windows with 782px #21661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +31 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 21, 2020
| @@ -151,13 +151,13 @@ | |||
| #{$selector} { /* Set left position when auto-fold is not on the body element. */ | |||
| left: 0; | |||
|
|
|||
| @include break-medium() { | |||
| @media (min-width: #{ ($break-medium + 1) }) { | |||
There was a problem hiding this comment.
Fun :) do you think the mixins should be updated to do this directly or not?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #19011
Before:
After:
How has this been tested?
I opened the editor in a 782px window.
I switched to a non-fullscreen mode.
I verified there was no empty space at the left and that the top of the editor looked right.