Try: output float clearing for all centered blocks. #21608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
Needs Design Feedback
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
5 tasks
|
I don't personally have a strong opinion here. It feels like CSS to support sort of an edgecase, which suggests we might not want to do it, and let themes handle it in the theme itself AND the editor. But at the same time, it does feel weird that a centered block following a floated block might look broken, and the fix is easy. So I created this PR to move things forward. If we choose to not do this, as mentioned, the way to address this is a user option as outlined in #21608. |
|
Size Change: +11 B (0%) Total Size: 839 kB
ℹ️ View Unchanged
|
ZebulanStanphill
approved these changes
Apr 15, 2020
|
Thank you Zeb! I'm going to actually leave this up for a while longer just to gather some more thoughts. |
|
Given there's been no feedback, through the law of diminishing returns and the fact that it's trivial to revert, I'm going to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs feedback. It is a replacement for #16780.
What it does is output a simple float-clearing rule for any block that is aligned center.
To test, insert two images. The first one you float left, the 2nd one you align center.
Before:
After:
To be perfectly clear, this is output in the editor and on the frontend.
In the past, this has been the purview of the theme itself, but lately there has been some discussion on how much or how little the editor should "help" here. That's why this PR needs discussion.