ESLint Plugin: Add the recommended Prettier config to enforce WP coding styles #21602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
changed the title
gziolo
added
[Package] ESLint plugin
4 tasks
|
Size Change: 0 B Total Size: 839 kB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/prettier-config-integration
branch
from
2e08ee4
to
8c033e8
Compare
aduth
approved these changes
Apr 15, 2020
|
Well, this will make code that was previously marked as correct now be marked as incorrect. But in some sense, it's a move back to the behaviour of 3.4.1 from the changes introduced in 4.0.0... (not 100%) |
|
I guess it can be fair if it falls under the realm of "Behavior which was never intended in the first place", to consider it as a bug fix. |
|
Yes, #20509 is marked as a bug, so this would be a bugfix, therefore not breaking |
|
I had it as a breaking change first, but it was never intended to allow the default Prettier coding style so bugfix seems reasonable. I'm doing a hotfix release soon, let's include this one as well, so most of the projects will get it together with breaking changes :) |
gziolo
added a commit
that referenced
this pull request
Apr 15, 2020
…ng styles (#21602) * ESLint Config: Add the recommended Prettier config to enforce WordPress coding styles * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20509. An alternative to #21503.
This PR always uses the recommended Prettier config to enforce WordPress coding styles but it respects the Prettier config overrides defined by projects.
It turns out that there is
usePrettierrcoption inprettier/prettierrule (https://github.com/prettier/eslint-plugin-prettier#options):This way we could remove the config in
@wordpress/scriptsfor Prettier and use@wordpress/prettier-configin all places instead.How has this been tested?
It's also possible to test the changes applied to the
@wordpress/eslint-configby removing.prettierrc.jsfile in the root of the project and executing:npm run lint-jsChecklist: