Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ CoreData Entities ] add support for delete operations #21557

Merged
merged 32 commits into from
Jul 28, 2020
Merged

[ CoreData Entities ] add support for delete operations #21557

merged 32 commits into from
Jul 28, 2020

Commits on Jun 30, 2020

  1. reset, delete nav menu items 

    there is a missing state preservation when menus are changed on the menus editor component
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    617e738 View commit details
    Browse the repository at this point in the history

  2. fixing a bad merge

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    fdceaa2 View commit details
    Browse the repository at this point in the history

  3. no invalidateCache and refactored according to review

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    1f8878b View commit details
    Browse the repository at this point in the history

  4. revert change to getMergedItemIds

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f4b6a83 View commit details
    Browse the repository at this point in the history

  5. refactor according to self review

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    e062c55 View commit details
    Browse the repository at this point in the history

  6. deletes query items, adds tests for new entity methods 

    also adds changelog
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    aa147ac View commit details
    Browse the repository at this point in the history

  7. refactored for properly deleteing entity ids from querries

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    315c77b View commit details
    Browse the repository at this point in the history

  8. updates tests

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d6bbb3f View commit details
    Browse the repository at this point in the history

  9. moved the REMOVE_ITEMS reducer to receive all query keys 

    props @aduth
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    4ef424d View commit details
    Browse the repository at this point in the history

  10. removes the need to send query on delete

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    24888af View commit details
    Browse the repository at this point in the history

  11. updates some comments 

    also removes cruft from a test
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9744cf3 View commit details
    Browse the repository at this point in the history

  12. refactoring according to review 

    - removes superfluous actions from deleteEntityRecords
- treats invalidateCache properly
- attempts to make lookups faster for items when removing querries
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    8f836b6 View commit details
    Browse the repository at this point in the history

  13. do not clear cache on delete

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    b657b19 View commit details
    Browse the repository at this point in the history

  14. fixes test after reming superfluous actions from deleteEntityRecord

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    c166e51 View commit details
    Browse the repository at this point in the history

  15. makes a proper POJO for removing items from queries and invalidates t… 

    …he cache after items are removed
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    360cbaa View commit details
    Browse the repository at this point in the history

  16. fix changelog and add deleteQueryParams to deleteRecord

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f87a8a6 View commit details
    Browse the repository at this point in the history

  17. fixes test

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    c7606a0 View commit details
    Browse the repository at this point in the history

  18. Rename deleteQueryParams to query for consistency

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    98ea4a8 View commit details
    Browse the repository at this point in the history

  19. Use the new deleteEntityRecord to delete menus (#22428) 

    * adds delete menu with entity delete

* updates the delete and removes the stateMenus

* passes the new force query param

* fix bug with resetting current menu after delete
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d55f893 View commit details
    Browse the repository at this point in the history

  20. fixes query param's type for consistency

    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    5abdf63 View commit details
    Browse the repository at this point in the history

  21. comment linting, removed useless catch logic for deleteEntityRecord, … 

    …removed useless string conversion
    @draganescu
    draganescu committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    eeded0c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. try implement error handling for delete

    @draganescu
    draganescu committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1995e69 View commit details
    Browse the repository at this point in the history

  2. fixed the intentional typo and the unintentional one

    @draganescu
    draganescu committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    b26e2e1 View commit details
    Browse the repository at this point in the history

  3. updates and fixes according to review

    @draganescu
    draganescu committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    be5b985 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. rename remove items' action id collection

    @draganescu
    draganescu committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8586489 View commit details
    Browse the repository at this point in the history

  2. makes notices unique in menu editor

    @draganescu
    draganescu committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ad3c7e7 View commit details
    Browse the repository at this point in the history

  3. Update packages/core-data/src/queried-data/actions.js 

    Co-authored-by: Enrique Piqueras <[email protected]>
    @draganescu @epiqueras
    draganescu and epiqueras authored Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3a6e36b View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. fixes bugs introduced by renaming items to itemsIds in the remove ite… 

    …ms action

also improves tests and made sure the notifications always have unique ids
    @draganescu
    draganescu committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    28f5b11 View commit details
    Browse the repository at this point in the history

  2. lint

    @draganescu
    draganescu committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    a34ee64 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. moves noticeId creation inside effect

    @draganescu
    draganescu committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    9a8d813 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. updated according to review 

    - test delete for final shape when generator is done
- simplify filter removing items from query
    @draganescu
    draganescu committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    59bb45c View commit details
    Browse the repository at this point in the history

  2. lint

    @draganescu
    draganescu committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    8051532 View commit details
    Browse the repository at this point in the history