Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete editor-styles that are no longer needed #21383

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Apr 3, 2020

Extracted from #20530 (comment)

These styles were used to prevent wp-admin styles from leaking to the editor. Now that the paragraph & heading blocks add their own variables for these properties, we need to remove them so global styles are applied.

How to test

Test that it works:

  • Create a new post with six heading blocks, representing each of the h1 to h6 elements.
  • Install this demo theme or add somewhere in your CSS these styles:
:root {
	--wp--color--background: pink;
	--wp--color--text: yellow;
	--wp--typography--line-height: 5;
}

body {
    background-color: var(--wp--color--background);
}
  • Verify that the colors and line-height are properly applied to the headings.

Now, test that it doesn't work without these changes:

  • Remove the last commit in this branch (git reset --hard HEAD~1) and compile again (npm run build).
  • Reload the editor and verify that:
    • the heading blocks don't have the color applied
    • h1-h4 blocks don't have the line-height applied

These were used to prevent wp-admin styles from leaking to the editor.
Now that the paragraph & heading blocks add their own variables
for these properties, we can remove these styles.
@oandregal oandregal self-assigned this Apr 3, 2020
@github-actions
Copy link

github-actions bot commented Apr 3, 2020

Size Change: -47 B (0%)

Total Size: 885 kB

Filename Size Change
build/editor/editor-styles-rtl.css 400 B -23 B (5%)
build/editor/editor-styles.css 402 B -24 B (5%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.45 kB 0 B
build/api-fetch/index.js 3.8 kB 0 B
build/autop/index.js 2.59 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.03 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 10.6 kB 0 B
build/block-editor/style.css 10.6 kB 0 B
build/block-library/editor-rtl.css 7.22 kB 0 B
build/block-library/editor.css 7.22 kB 0 B
build/block-library/index.js 110 kB 0 B
build/block-library/style-rtl.css 7.53 kB 0 B
build/block-library/style.css 7.54 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 16.6 kB 0 B
build/components/style.css 16.5 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.7 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.23 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.05 kB 0 B
build/edit-navigation/index.js 2.71 kB 0 B
build/edit-navigation/style-rtl.css 239 B 0 B
build/edit-navigation/style.css 241 B 0 B
build/edit-post/index.js 92.5 kB 0 B
build/edit-post/style-rtl.css 12.1 kB 0 B
build/edit-post/style.css 12.1 kB 0 B
build/edit-site/index.js 9.78 kB 0 B
build/edit-site/style-rtl.css 4.68 kB 0 B
build/edit-site/style.css 4.68 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 3.74 kB 0 B
build/edit-widgets/style.css 3.74 kB 0 B
build/editor/index.js 42.8 kB 0 B
build/editor/style-rtl.css 3.49 kB 0 B
build/editor/style.css 3.49 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.7 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.5 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.6 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@oandregal oandregal marked this pull request as ready for review April 3, 2020 16:14
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Apr 3, 2020
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, we can potentially apply them as fallbacks to the variables but I believe it's not really needed right?

@jasmussen
Copy link
Contributor

I'm out for the day, but I trust Riad totally. I'd also say that regardless of whatever small things might be affected, this is a crucially important step to take, so go forth and conquer!

@oandregal
Copy link
Member Author

This makes sense to me, we can potentially apply them as fallbacks to the variables but I believe it's not really needed right?

I don't have a strong opinion either way. However, I lean towards not adding them: this was only previously done for the editor while adding now the fallbacks will affect both the editor & frontend. When we load the global styles they're going to be pre-filled anyway, so I guess we can land as it is.

@oandregal oandregal merged commit a97f31c into master Apr 6, 2020
@oandregal oandregal deleted the delete/editor-styles branch April 6, 2020 09:27
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants