Preload the edited template to avoid the white page effect before the screen loads #21214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
|
Nice! |
|
Size Change: +3 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/preload-edit-site-template
branch
from
ce3ec83
to
ab333ba
Compare
There was a problem hiding this comment.
This works well! Very nice.
I see from the comment the preload paths are taken from edit-forms-blocks.php. Do all of these items in the path make sense to have preloaded for the site editor? By the looks of it most of them seem appropriate, but Im not certain.
Anyways, testing this change I do see a noticeable difference!
lib/edit-site-page.php
Outdated
| '/wp/v2/taxonomies?per_page=-1&context=edit', | ||
| '/wp/v2/themes?status=active', | ||
| sprintf( '/wp/v2/templates/%s?context=edit', $_wp_current_template_id ), | ||
| '/wp/v2/users/me?post_type=templates&context=edit', |
There was a problem hiding this comment.
does having post_type=templates make sense here? For the site editor isn't our post type undefined ?
There was a problem hiding this comment.
I think our post type is wp_template actually, so yeah that might be the only unused entry here, I'll test it.
youknowriad
force-pushed
the
add/preload-edit-site-template
branch
from
f2a7f99
to
00628bd
Compare
youknowriad
force-pushed
the
add/preload-edit-site-template
branch
from
00628bd
to
04e454a
Compare
youknowriad
commented
Mar 30, 2020
| @@ -139,6 +139,9 @@ const ColorPanel = ( { colorSettings, clientId } ) => { | |||
|
|
|||
| useEffect( () => { | |||
| const colorsDetectionElement = getBlockDOMNode( clientId ); | |||
| if ( ! colorsDetectionElement ) { | |||
There was a problem hiding this comment.
This is a small unrelated bug fix that was causing some blocks (template part) to fail in the edit site page.
Addison-Stavlo
approved these changes
Mar 31, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the screen loads as a white page before the API fetching the template finishes. This PR fixes that by preloading the template.