[RNMobile] Latest-Posts: Resolve issue with Query Controls, and fix API Fetch strategy #21025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsnyder
added
[Type] Bug
chipsnyder
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
Merged
2 tasks
|
Size Change: -74 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
|
@chipsnyder just an heads up, I think you need to target the master branch and then @marecar3 will cherry pick from there to the release branch. |
chipsnyder
force-pushed
the
rnmobile/issue-2038-apiFetch
branch
from
2a69863 to
97c57ba
Compare
7 tasks
marecar3
pushed a commit
that referenced
this pull request
Mar 20, 2020
…PI Fetch strategy (#21025) * Convert the categories fetchRequest to use the apiFetch API for cacheing * Fix Conflict in Query Controls to move the stable state to Mobile * Fix Conflict in Query Controls to move the stable state to Mobile
This was referenced Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2038
gutenberg-mobile:wordpress-mobile/gutenberg-mobile#2039Description
API
Adjusts the fetching of categories from using
fetchRequestto useapiFetchwhich also removed the need for casting the platform response and converting it to JSON for AndroidQueryControls
#20832 Introduced an issue with Query Controls in order to maintain the stable state of these controls I cloned that file to
index.native.jsand removed the mobile-specific code in the old file. There seem to be a lot of planned changes there so we can probably reassess combining them later.Style change
Resolved the issue mentioned here #20301 (comment)
How has this been tested?
Tested following the steps here: #20301
Types of changes
Checklist: