-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Include npm run dev
guidance in "Getting Started"
#21015
Conversation
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tangent:
Note: The install scripts require Python to be installed and in the path of the local system.
Is this still a thing? It took me by surprise.
I've not encountered it myself, though likely because I've always had Python available. Based on #18436, and specifically @mkaz's comment at #18436 (review), I suspect it is likely still a prerequisite to include.
|
Three intermittent end-to-end failings in a row, from a simple documentation pull request 😞 ...Force-merge it is! |
Context (link requires registration): https://wordpress.slack.com/archives/C02QB2JS7/p1584622721035100
Despite being the best option for builds when doing continued development in the project, the documentation currently includes no reference to
npm run dev
. This pull request seeks to add such a mention, immediately following the initialnpm run build
example. In relation to thenpm run build
, the given text intentionally provides some contextual contrast to differentiatedev
frombuild
.Testing Instructions:
As this pull request affects only documentation, it is not expected to have any impact on the application runtime.