Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimentalUIParts API #20979

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Remove experimentalUIParts API #20979

merged 1 commit into from
Mar 26, 2020

Conversation

youknowriad
Copy link
Contributor

This PR removes the experimentalUIParts API as this became useless with the G2 refactoring.

cc @ockham

@youknowriad youknowriad added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 18, 2020
@youknowriad youknowriad self-assigned this Mar 18, 2020
@github-actions
Copy link

Size Change: -163 B (0%)

Total Size: 857 kB

Filename Size Change
build/block-editor/index.js 100 kB -146 B (0%)
build/block-library/index.js 111 kB -17 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.52 kB 0 B
build/edit-post/style.css 8.51 kB 0 B
build/edit-site/index.js 5.07 kB 0 B
build/edit-site/style-rtl.css 2.53 kB 0 B
build/edit-site/style.css 2.53 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 44 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@youknowriad youknowriad requested review from vindl and gziolo March 20, 2020 13:18
@gziolo
Copy link
Member

gziolo commented Mar 21, 2020

Do you know the initial commit that introduced it? It’d make it easier reviewing 😃

Code looks good but I might overlook something.

@Soean
Copy link
Member

Soean commented Mar 21, 2020

@gziolo cd01549

@youknowriad
Copy link
Contributor Author

I'm merging this now, We can revert it if there's feedback suggesting it's still important.

@youknowriad youknowriad merged commit 516f022 into master Mar 26, 2020
@youknowriad youknowriad deleted the remove/experimentalUIPartsAPI branch March 26, 2020 10:05
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Mar 26, 2020
@ockham
Copy link
Contributor

ockham commented Mar 26, 2020

Thanks @youknowriad! I haven't really kept up with G2, would you have any pointers as to how we can disable the block toolbar now? 😅 (That's what we were using hasPopover for.)

@sirreal
Copy link
Member

sirreal commented May 15, 2020

A bit late. This is the first I'm coming across this after tracking it down as the cause of this issue: Automattic/wp-calypso#42031 (review)

hasPopover was introduced in #19922, which was added to support rendering a BlockList without a Block toolbar. I know it was an experimental API, but this will be a regression for our consuming application. We'll need to resort to CSS hiding the block toolbar in order to upgrade the block-editor package.

What were the motivations for removal? Can we restore this functionality?

@sirreal sirreal mentioned this pull request May 15, 2020
Merged
1 task
sirreal added a commit to Automattic/wp-calypso that referenced this pull request May 15, 2020
@sirreal
Remove block toolbar via CSS
7e1fb10 
Experimental UI parts api was dropped in
WordPress/gutenberg#20979

Remove usage and hide via CSS
roo2 pushed a commit to Automattic/wp-calypso that referenced this pull request May 18, 2020
@renovate @renovate-bot
@sirreal @scinos
fix(deps): update wordpress monorepo (#42031)
7258ca3 
* fix(deps): update wordpress monorepo
* Deduplicate @WordPress packages
* Remove block toolbar via CSS

Experimental UI parts api was dropped in
WordPress/gutenberg#20979

Remove usage and hide via CSS

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Jon Surrell <[email protected]>
Co-authored-by: Sergio Cinos <[email protected]>
@ockham
Copy link
Contributor

ockham commented May 18, 2020

I just chatted with @youknowriad. He told me that Gutenberg folks are generally opposed to keeping an experimental API that isn't used in the project itself and where the use-case is not very wide for third-party plugins.

He had an alternative suggestion though:

Hide the block toolbar for blocks that don't have any block controls, and that live inside a locked template (such as).

We're both not entirely sure if we'd inadvertently prevent any other block interactions that way, but agreed that it might be worth exploring in a PR and soliciting feedback that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@ellatrix ellatrix Awaiting requested review from ellatrix

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@vindl vindl Awaiting requested review from vindl

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@youknowriad youknowriad

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 7.9
Development

Successfully merging this pull request may close these issues.
5 participants
@youknowriad @gziolo @Soean @ockham @sirreal