Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Update all webpack related dependencies #20916

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Mar 16, 2020

Description

Fixes #20088.

Introduced in: #18243

Related slack discussion: https://wordpress.slack.com/archives/C5UNMSU4R/p1580939781306900

Reason for bug: Incompatibility between @svgr/webpack:4.3.3 and url-loader:3.0.0 which was fixed in @svgr/webpack:5.0.0 as documented in gregberge/svgr#367.

The proposed solution is to update @svgr/webpack to version 5.0 or greater.

This PR fixes incompatibility between @svgr/webpack in version 4.3.3 and url-loader in version 3.0.0 by bumping @svgr/webpack to ^5.2.0.

In addition, all webpack dependencies got minor version update if applicable.

How has this been tested?

npm run dev
npm run build

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Tool] WP Scripts /packages/scripts labels Mar 16, 2020
@gziolo gziolo self-assigned this Mar 16, 2020
@github-actions
Copy link

github-actions bot commented Mar 16, 2020

Size Change: -137 B (0%)

Total Size: 856 kB

Filename Size Change
build/a11y/index.js 998 B -8 B (0%)
build/annotations/index.js 3.42 kB -2 B (0%)
build/autop/index.js 2.58 kB -1 B
build/block-directory/index.js 6.02 kB -3 B (0%)
build/block-editor/index.js 100 kB +17 B (0%)
build/block-library/index.js 111 kB -5 B (0%)
build/block-serialization-default-parser/index.js 1.65 kB -1 B
build/blocks/index.js 57.6 kB -120 B (0%)
build/components/index.js 191 kB -90 B (0%)
build/compose/index.js 6.21 kB -4 B (0%)
build/core-data/index.js 10.6 kB +5 B (0%)
build/data-controls/index.js 1.04 kB +1 B
build/data/index.js 8.2 kB -14 B (0%)
build/dom/index.js 3.06 kB -7 B (0%)
build/edit-post/index.js 91.3 kB -26 B (0%)
build/edit-site/index.js 4.63 kB -6 B (0%)
build/edit-widgets/index.js 4.44 kB -7 B (0%)
build/editor/index.js 43.9 kB +134 B (0%)
build/element/index.js 4.45 kB +5 B (0%)
build/format-library/index.js 7.09 kB -6 B (0%)
build/hooks/index.js 1.93 kB +6 B (0%)
build/keyboard-shortcuts/index.js 2.3 kB -1 B
build/keycodes/index.js 1.69 kB +2 B (0%)
build/media-utils/index.js 4.84 kB -8 B (0%)
build/notices/index.js 1.58 kB +4 B (0%)
build/nux/index.js 3.01 kB +2 B (0%)
build/plugins/index.js 2.54 kB -4 B (0%)
build/primitives/index.js 1.5 kB +8 B (0%)
build/priority-queue/index.js 780 B +1 B
build/redux-routine/index.js 2.84 kB -1 B
build/rich-text/index.js 14.3 kB -5 B (0%)
build/url/index.js 4.01 kB +3 B (0%)
build/viewport/index.js 1.61 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/api-fetch/index.js 3.39 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/edit-post/style-rtl.css 8.62 kB 0 B
build/edit-post/style.css 8.62 kB 0 B
build/edit-site/style-rtl.css 2.53 kB 0 B
build/edit-site/style.css 2.53 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@gziolo gziolo force-pushed the update/scripts-webpack branch from 1056faf to a22e276 Compare March 16, 2020 09:52
@gziolo gziolo merged commit ed53b0f into master Mar 16, 2020
@gziolo gziolo deleted the update/scripts-webpack branch March 16, 2020 13:34
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] WP Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing SVG with @wordpress/scripts
2 participants