-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies webpack plugin: Let the output file be specified when output is combined #20844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
A suggestion for improvement.
[Tool] Dependency Extraction Webpack Plugin
/packages/dependency-extraction-webpack-plugin
labels
Mar 12, 2020
gziolo
force-pushed
the
update/webpack-dependency-plugin-output-file
branch
from
March 12, 2020 18:52
9522ee6
to
8ed80ad
Compare
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
Works as expected, thanks! Added local copy of DependencyExtractionPlugin to core trunk and tested with |
azaozz
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Tool] Dependency Extraction Webpack Plugin
/packages/dependency-extraction-webpack-plugin
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20562.
The plugin now supports an optional
combinedOutputFile
option that is useful only when anothercombineAssets
option is enabled. It allows providing a custom output file for the generated single assets file.How has this been tested?
I used the following diff to ensure that the new option is respected:
Types of changes
New feature (non-breaking change which adds functionality).
Checklist: