-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Remove left border of the toolbar #20830
Conversation
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you @Tug 🙏
Tested on iOS and Android, and Accessibility didn't get affected 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Description
This PR removes the left border for the toolbar on mobile.
It does so by removing the
<Toolbar>
element that wrapped the inserter and the undo/redo buttons. This also brings us closer to the web code that doesn't have it.Gutenberg Mobile related PR: wordpress-mobile/gutenberg-mobile#2004
How has this been tested?
Visual test (check GB Mobile PR)
Screenshots
New look:
Types of changes
Visual change
Checklist: