-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create block: Improve how prompts and values provided are handled #20756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
A suggestion for improvement.
[Tool] Create Block
/packages/create-block
labels
Mar 10, 2020
5 tasks
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
aduth
reviewed
Mar 10, 2020
gziolo
force-pushed
the
update/create-block-prompts
branch
from
March 11, 2020 11:06
228dbde
to
5367b7e
Compare
aduth
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by #20694 and work done by @pereirinha to add
readme.txt
file.This PR ensures that optional values are reflected in the generated code and therefore they are wrapped with conditionals that ensure they are only printed when provided.
In addition:
How has this been tested?
Testing is a bit tricky for this package because it is usually executed from npm. However, there is a way to run this script from Gutenberg:
npx wp-create-block
for ESNextnpx wp-create-block --template es5
for ES5The best way is to omit optional marked as such and observe the scaffolded block.
Checklist: