-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeControl: Improve disabled rendering and interactions #20723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
March 9, 2020 13:27
Size Change: +68 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
Nice, this is looking good. |
ItsJonQ
force-pushed
the
fix/range-control-disabled-ui
branch
from
March 18, 2020 16:21
2274ca2
to
7fbf229
Compare
mtias
approved these changes
Mar 18, 2020
This update improves the UI rendering of the RangeControl, sepcifically by muting the Rail, Track, and Marks. The disabled prop is also passed along to the inner (number) Input and Reset value button.
ItsJonQ
force-pushed
the
fix/range-control-disabled-ui
branch
from
March 18, 2020 20:31
7fbf229
to
24f1021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update improves the UI rendering of the RangeControl, specifically by muting the Rail, Track, and Marks. The disabled prop is also passed along to the inner (number) Input and Reset value button.
How has this been tested?
Tested locally on Gutenberg and Storybook
Screenshots
Types of changes
Checklist:
Resolves: #20319