Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default login credentials and wp-env run command #20678

Merged
merged 8 commits into from
Mar 16, 2020

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Mar 6, 2020

Description

When I've been getting up to speed with wp-env, I've been struggling with:

  • Logging in to my new WordPress
  • Running WP CLI commands

This PR documents both of these in README.

Types of changes

non-breaking changes

@draganescu draganescu added the [Type] Developer Documentation Documentation for developers label Mar 6, 2020
@adamziel adamziel changed the title Document default login credentials and run command Document default login credentials and wp-env run command Mar 6, 2020
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 good additions, left a few non critical comments

packages/env/README.md Show resolved Hide resolved
```sh
wp-env run <container> [command..]

Runs an arbitrary command in one of the underlying Docker containers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice for those Ctrl+F ing through docs to mention here "for example running wp cli commands". I know you added this to the exanples, it would be nice make the connection immediately.

Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@draganescu draganescu merged commit e8b5c2e into WordPress:master Mar 16, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 16, 2020
@noahtallen
Copy link
Member

Thanks for this change!

@earnjam earnjam mentioned this pull request Mar 20, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants