-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document default login credentials and wp-env run
command
#20678
Conversation
wp-env run
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 good additions, left a few non critical comments
packages/env/README.md
Outdated
```sh | ||
wp-env run <container> [command..] | ||
|
||
Runs an arbitrary command in one of the underlying Docker containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice for those Ctrl+F ing through docs to mention here "for example running wp cli commands". I know you added this to the exanples, it would be nice make the connection immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for this change! |
Description
When I've been getting up to speed with wp-env, I've been struggling with:
This PR documents both of these in README.
Types of changes
non-breaking changes