Block Editor: Use full labels for directional block movers #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
ocean90
approved these changes
Mar 5, 2020
youknowriad
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 10, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 10, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20655
Regressed in #16615
This pull request seeks to resolve an issue where block mover labels cannot be fully translated, due to concatenation (
sprintf) of the translated label with non-translated directional strings ("up", "down", "right", "left").The changes in this pull request reintroduce labels which had existed prior to #16615 (plus horizontal additions), in their fully expanded form. Per discussion in #20655, this is considered to be preferable to placeholder substitution, where the short directional strings are more difficult to translate than the full labels.
Note about cherry-picking for WordPress 5.4:
It's unclear to me whether this is allowable to be cherry-picked for 5.4, given that the WordPress 5.4 RC was already released this Tuesday, and which is considered (by its announcement post) as a hard string freeze. Without these new strings, however, it is impossible to correctly translate the block mover labels.Based on @ocean90's comment at #20655 (comment), it should be fine to cherry-pick these changes for WordPress 5.4.Testing Instructions:
Repeat Testing Instructions from #16615, verifying no regressions in expected behavior.
For complete testing of strings, you could run
wp i18n make-poton the built output of the file to confirm the strings "Move left", "Move up", "Move right', and "Move down" are correctly available for translation.