-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Latest Posts ] Testing larger margins #20563
Conversation
cc @karmatosed you can checkout this branch and see if 20px works best. @tellthemachines could you help please me find where this rule is coming from:
and gets applied to all |
Size Change: +80 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
I don't see that rule applying to that element on master branch. What properties is it defining? |
daa80a2
to
d5b42c6
Compare
@tellthemachines I can't see it either now :) I think it was while I had some issues with my building system. Thanks for checking it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the 20px works, for now, we could probably increase as grid work happens throughout, however, for now, it improves the current situation. Thanks for doing this! Approving based on design so still needs code review.
Description
Closes #19421
How has this been tested?
Tested locally.
Screenshots
Types of changes
Modified the margin of posts in
LatesPosts
grid view to 20 px.Checklist: