Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Extend current Button settings with automatically pasting link #20462

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Feb 26, 2020

Description

Fixes: wordpress-mobile/gutenberg-mobile#1957 (comment)
Ref to gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1958

  • Extend current Button setting to get automatically link pasting into button settings.
  • Add autofocus on Button Link URL field like in other examples

How has this been tested?

  1. Copy link into clipboard, e.g: http://apple.com
  2. Open mobile app
  3. Add Button block
  4. Open Button settings
  5. Notice if link is automatically pasted into Button Link URL field

Screenshots

Types of changes

Enhancements:

  • Extend current Button setting to get automatically link pasting into button settings.
  • Add autofocus on Button Link URL field like in other examples

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 26, 2020
@github-actions
Copy link

github-actions bot commented Feb 26, 2020

Size Change: +61 B (0%)

Total Size: 865 kB

Filename Size Change
build/block-editor/style-rtl.css 10.3 kB +12 B (0%)
build/block-editor/style.css 10.3 kB +12 B (0%)
build/block-library/editor-rtl.css 7.66 kB -3 B (0%)
build/block-library/editor.css 7.66 kB -2 B (0%)
build/block-library/index.js 116 kB -1 B
build/block-library/style-rtl.css 7.49 kB +2 B (0%)
build/block-library/style.css 7.5 kB +3 B (0%)
build/i18n/index.js 3.48 kB +38 B (1%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 90.9 kB 0 B
build/edit-post/style-rtl.css 8.59 kB 0 B
build/edit-post/style.css 8.58 kB 0 B
build/edit-site/index.js 4.62 kB 0 B
build/edit-site/style-rtl.css 2.51 kB 0 B
build/edit-site/style.css 2.51 kB 0 B
build/edit-widgets/index.js 4.41 kB 0 B
build/edit-widgets/style-rtl.css 2.59 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 325 B 0 B
build/editor/editor-styles.css 327 B 0 B
build/editor/index.js 44.6 kB 0 B
build/editor/style-rtl.css 4.01 kB 0 B
build/editor/style.css 4 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 879 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@pinarol pinarol requested a review from chipsnyder February 26, 2020 13:34
@chipsnyder
Copy link
Contributor

@lukewalczak Testing through some of this now and just wanted to confirm a finding. For a string like apple.com should I expect that to appear in the link text field?

@lukewalczak
Copy link
Member Author

lukewalczak commented Feb 26, 2020

👋 @chipsnyder , I assumed that according to logic for checking a copied string into the clipboard, you should expect that http://apple.com will appear in link text field.

EDIT: I meant that http://apple.com will appear if exactly that string was copied into the clipboard. If you copied just apple.com it shouldn't appear.

@chipsnyder
Copy link
Contributor

http://apple.com will appear if exactly that string was copied into the clipboard. If you copied just apple.com it shouldn't appear.

👍 That's what I was seeing. Tested the use cases above with block settings and the link attributes. LGTM!

@lukewalczak
Copy link
Member Author

I've updated also Button test case according to changes: wordpress-mobile/test-cases#9

@lukewalczak lukewalczak merged commit 4dd6a8c into master Feb 27, 2020
@lukewalczak lukewalczak deleted the rnmobile/paste-link-into-button-settings branch February 27, 2020 10:05
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
2 participants