Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Latest Posts] Add filtering by author #20415

Closed
wants to merge 3 commits into from

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Feb 24, 2020

Description

Adds an Author filter to the LatestPosts block.

How has this been tested?

Tested locally by:

  1. Making sure I have posts by multiple authors
  2. Creating a post
  3. Adding a LatestPosts block
  4. Setting the Author to some author

Screenshots

latest-posts-author

Types of changes

Non breaking filter addition to QueryControls component and LatestPosts block.

@github-actions
Copy link

github-actions bot commented Feb 24, 2020

Size Change: +828 B (0%)

Total Size: 865 kB

Filename Size Change
build/a11y/index.js 1 kB -1 B
build/block-editor/index.js 104 kB -276 B (0%)
build/block-editor/style-rtl.css 10.3 kB +558 B (5%) 🔍
build/block-editor/style.css 10.3 kB +562 B (5%) 🔍
build/block-library/editor-rtl.css 7.67 kB -4 B (0%)
build/block-library/index.js 116 kB +1.48 kB (1%)
build/block-serialization-default-parser/index.js 1.65 kB +1 B
build/blocks/index.js 57.6 kB +1 B
build/components/index.js 190 kB +99 B (0%)
build/components/style-rtl.css 15.5 kB -529 B (3%)
build/components/style.css 15.5 kB -535 B (3%)
build/compose/index.js 5.76 kB -2 B (0%)
build/data-controls/index.js 1.03 kB -1 B
build/data/index.js 8.22 kB +1 B
build/date/index.js 5.37 kB +4 B (0%)
build/deprecated/index.js 772 B +1 B
build/dom-ready/index.js 568 B -1 B
build/dom/index.js 3.06 kB -1 B
build/edit-post/index.js 90.9 kB +227 B (0%)
build/edit-post/style-rtl.css 8.68 kB -23 B (0%)
build/edit-post/style.css 8.67 kB -18 B (0%)
build/edit-site/index.js 4.59 kB +12 B (0%)
build/edit-widgets/index.js 4.36 kB -1 B
build/edit-widgets/style-rtl.css 2.8 kB -1 B
build/editor/editor-styles-rtl.css 325 B -2 B (0%)
build/editor/editor-styles.css 327 B -1 B
build/editor/index.js 44.6 kB -518 B (1%)
build/editor/style-rtl.css 4.01 kB -115 B (2%)
build/editor/style.css 4 kB -111 B (2%)
build/element/index.js 4.45 kB -2 B (0%)
build/format-library/index.js 7.6 kB +3 B (0%)
build/format-library/style-rtl.css 502 B +2 B (0%)
build/format-library/style.css 502 B +1 B
build/html-entities/index.js 622 B +1 B
build/i18n/index.js 3.45 kB -1 B
build/is-shallow-equal/index.js 710 B -1 B
build/keyboard-shortcuts/index.js 2.3 kB +4 B (0%)
build/list-reusable-blocks/style-rtl.css 226 B +11 B (4%)
build/list-reusable-blocks/style.css 226 B +10 B (4%)
build/media-utils/index.js 4.85 kB -1 B
build/nux/index.js 3.02 kB +1 B
build/plugins/index.js 2.54 kB +1 B
build/priority-queue/index.js 879 B +1 B
build/redux-routine/index.js 2.84 kB +2 B (0%)
build/rich-text/index.js 14.3 kB -1 B
build/server-side-render/index.js 2.54 kB -2 B (0%)
build/token-list/index.js 1.27 kB -1 B
build/url/index.js 4 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/editor.css 7.67 kB 0 B
build/block-library/style-rtl.css 7.49 kB 0 B
build/block-library/style.css 7.49 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/edit-site/style-rtl.css 2.77 kB 0 B
build/edit-site/style.css 2.76 kB 0 B
build/edit-widgets/style.css 2.79 kB 0 B
build/escape-html/index.js 733 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.49 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@pbrocks
Copy link

pbrocks commented Apr 3, 2020

Using Gutenberg.run, I imported via XML posts from a few different sources making sure to have multiple authors. However, none of the imported "authors" of the posts showed up in the dropdown because they were imported as subscribers. While this is probably the correct behavior, it may be worth noting that changing the user role to contributor will also work since they can edit_posts. Otherwise, works as expected.

min-role-contrib-gutenberg-run

@draganescu
Copy link
Contributor Author

I will close this in favor of #16169

@draganescu draganescu closed this Apr 30, 2020
@aristath aristath deleted the add/author-to-latest-posts branch November 10, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants