Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Removing DEV flag for Image block size options #20229

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

cameronvoell
Copy link
Member

@cameronvoell cameronvoell commented Feb 14, 2020

Description

We recently finished resolving behavioral issues related to updating images sizes on mobile, and are therefore removing the DEV flag blocking the feature in non-development builds.
See - wordpress-mobile/gutenberg-mobile#1593

Related PRs

Gutenberg-Mobile: wordpress-mobile/gutenberg-mobile#1904

How has this been tested?

Individual changes have all already been tested as seen in the PRs linked in this issue wordpress-mobile/gutenberg-mobile#1593

Screenshots

size-changes

Types of changes

We are removing DEV flag blocking a feature now that all known issues are resolved.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@cameronvoell cameronvoell changed the title Removing DEV flag for Image block size options [RNMobile]Removing DEV flag for Image block size options Feb 14, 2020
@cameronvoell cameronvoell changed the title [RNMobile]Removing DEV flag for Image block size options [RNMobile] Removing DEV flag for Image block size options Feb 14, 2020
@cameronvoell cameronvoell marked this pull request as ready for review February 14, 2020 07:49
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@cameronvoell cameronvoell merged commit 76d25bf into master Feb 14, 2020
@cameronvoell cameronvoell deleted the rnmobile/remove-dev-flag-image-size-options branch February 14, 2020 15:23
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants