wp-env: Fix issue where docker & wp had different URLs #20228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Bug
epiqueras
requested changes
Feb 14, 2020
noahtallen
force-pushed
the
fix/wp-env-install-p'rt
branch
2 times, most recently
from
9c3ac2f to
b1e642b
Compare
epiqueras
approved these changes
Feb 14, 2020
Co-Authored-By: Enrique Piqueras <[email protected]>
noahtallen
force-pushed
the
fix/wp-env-install-p'rt
branch
from
3bee527 to
985d30c
Compare
|
Rebased; hopefully that will fix the failing e2e test |
noahtallen
changed the title
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
- Fixed: docker and WP had different URLs Caused by WordPress install not using the .wp-env.json custom port values, so it would redirect you to the default port. - Added: validation function for numeric env vars - Added: tests to validate port override behavior
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
- Fixed: docker and WP had different URLs Caused by WordPress install not using the .wp-env.json custom port values, so it would redirect you to the default port. - Added: validation function for numeric env vars - Added: tests to validate port override behavior
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where a custom port in .wp-env.json would not change the URL used to install WordPress. This resulted in the WordPress redirecting you to the default port. So if you would access docker at localhost:4013, it would send the request to WordPress, which thought the URL was localhost:8888, and you'd then be redirected to localhost:8888 which had nothing running on it.
How has this been tested?
I made sure that accessing the custom port in .wp-env.json correctly loaded WordPress on that port. I also added unit tests to verify that environment variables are validated and take precedent over config values.
Types of changes
Bug fix
Checklist: