Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeControl: Improve initial hover interaction with Tooltip #20219

Merged
merged 8 commits into from
Feb 20, 2020
Merged

RangeControl: Improve initial hover interaction with Tooltip #20219

merged 8 commits into from
Feb 20, 2020

Commits on Feb 13, 2020

  1. RangeControl: Improve initial hover interaction with Tooltip 

    This update improves the initial hover/mouseenter experience with the RangeControl's Tooltip. This is achieved be debouncing the interaction. By debouncing, the Tooltip rendering is less jarring when there are multiple `RangeControl` components next to each other.

A Storybook story was added to test and simulate this experience.

Lastly, the utility functions/hooks from `RangeControl` was abstracted to a dedicated `utils.js` file under the component directory.
    Jon Q committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    c898977 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Simplifies setValue to be a plain function vs using useCallback

    Jon Q committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3454646 View commit details
    Browse the repository at this point in the history

  2. Remove local ref from useCallback hook

    Jon Q committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    1e6528a View commit details
    Browse the repository at this point in the history

  3. Remove guard for clearTimeout

    Jon Q committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    ad29531 View commit details
    Browse the repository at this point in the history

  4. Add clearTimeout callback on unmount

    Jon Q committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    733c5d4 View commit details
    Browse the repository at this point in the history

  5. Improve Tooltip rendering for current RangeControl changes... 

    ...with other RangeControl hover interactions.
    Jon Q committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    c8e6cf6 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Merge branch 'master' into update/range-control-tooltip-initial-inter… 

    …action
    Jon Q committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    e6752a4 View commit details
    Browse the repository at this point in the history

  2. Removed whitespace + adjusted setState naming

    Jon Q committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    ddc3507 View commit details
    Browse the repository at this point in the history