[FIX] inserter point in mobile app #20195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
changed the title
Merged
2 tasks
|
It also covers below test scenarios from other PR connected with Appender/Separator:
With this one there should be no more regression in changes implemented so far. |
pinarol
reviewed
Feb 18, 2020
packages/block-editor/src/components/block-list/index.native.js
Outdated
Show resolved
Hide resolved
Tug
approved these changes
Feb 18, 2020
| @@ -116,6 +118,10 @@ export class BlockList extends Component { | |||
| scrollViewStyle={ { flex: isRootList ? 1 : 0 } } | |||
| data={ blockClientIds } | |||
| keyExtractor={ identity } | |||
| extraData={ | |||
| shouldShowInsertionPointBefore || | |||
There was a problem hiding this comment.
we could define a forceRefresh variable that has this value and use it here, it would make this change more explicit
There was a problem hiding this comment.
This would increase code readability
pinarol
approved these changes
Feb 18, 2020
mchowning
pushed a commit
that referenced
this pull request
Feb 18, 2020
* fix inserter point in gutenberg-mobile
mchowning
added a commit
that referenced
this pull request
Feb 22, 2020
* Add view with accesibility label on top of floating toolbar (#20267) * [FIX] inserter point in mobile app (#20195) * fix inserter point in gutenberg-mobile * Make sure that all strong tags are removed from title. (#20291) Co-authored-by: Drapich Piotr <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1894
I found an issue with the inserter point in the mobile app. The inserter was rendered even if the Add block bottom sheet was hidden. Look at the screen:
It happens because we removed the
extraDataprop from FlatList. Because of that if thedatais the same (it is the same in the case when we open bottom sheet and hide it- we don't change anything ) therenderItemis not called and we end with the wrong state of list items (they are not re-rendered after change of props).I also fixed the inserter for the first block in an empty post. The Inserter should be rendered instead of a paragraph placeholder.
How has this been tested?
add beforeoradd afterand check if inserter is in the right placeScreenshots
Types of changes
Fix for inserter
Checklist: