Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Enable gallery upload options in production #20043

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Feb 5, 2020

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

How has this been tested?

To test: wordpress-mobile/gutenberg-mobile#1610 (comment)

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@geriux
Copy link
Member

geriux commented Feb 10, 2020

👋 I've just tested this on iOS wordpress-mobile/WordPress-iOS#13374

Used different network speeds in each case.

✅Choose from device (stay in editor) - Successful upload
✅Choose from device (stay in editor) - Failed upload
✅Choose from device (leave the editor) - Successful upload
✅Choose from device (close and re-open the editor with ongoing uploads)
✅Take a photo
❗️Choose from the free photo library [as noted in the test cases on iOS only appends the first picture.]

The PRs are in draft, @mkevins is there more work planned on these? Regarding the free photo library, I guess we are going to work on that on a separate PR right? Let me know so I can approve these ones.

Nice work! 👏

@mkevins
Copy link
Contributor Author

mkevins commented Feb 10, 2020

Hi @geriux 👋 Thanks for testing and reviewing

The PRs are in draft, @mkevins is there more work planned on these? Regarding the free photo library, I guess we are going to work on that on a separate PR right? Let me know so I can approve these ones.

These were in draft mainly because it wasn't clear early on whether the fixes for the known issues would be added to this, or if they'd require significant changes to the diff. It turned out, no major changes were needed, aside from the parent app PRs which have separate PRs to address those issues.

The free photo library fix here wordpress-mobile/WordPress-iOS#13404 targets the related WordPress-iOS PR noted in the description above.

@mkevins mkevins marked this pull request as ready for review February 11, 2020 08:04
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! Tested following wordpress-mobile/gutenberg-mobile#1610 (comment) 🚀

LGTM!

@mkevins mkevins merged commit fefa7e9 into master Feb 13, 2020
@mkevins mkevins deleted the rnmobile/enable-gallery-upload-in-production branch February 13, 2020 02:58
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Media Anything that impacts the experience of managing media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants