-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Enable gallery upload options in production #20043
Conversation
👋 I've just tested this on iOS wordpress-mobile/WordPress-iOS#13374 Used different network speeds in each case. ✅Choose from device (stay in editor) - Successful upload The PRs are in draft, @mkevins is there more work planned on these? Regarding the free photo library, I guess we are going to work on that on a separate PR right? Let me know so I can approve these ones. Nice work! 👏 |
Hi @geriux 👋 Thanks for testing and reviewing
These were in draft mainly because it wasn't clear early on whether the fixes for the known issues would be added to this, or if they'd require significant changes to the diff. It turned out, no major changes were needed, aside from the parent app PRs which have separate PRs to address those issues. The free photo library fix here wordpress-mobile/WordPress-iOS#13404 targets the related WordPress-iOS PR noted in the description above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved with wordpress-mobile/gutenberg-mobile#1610 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!! Tested following wordpress-mobile/gutenberg-mobile#1610 (comment) 🚀
LGTM!
Sibling PRs
gutenberg-mobile
: Enable gallery upload options in production wordpress-mobile/gutenberg-mobile#1855WordPress-Android
: Enable gallery upload options in production wordpress-mobile/WordPress-Android#11234WordPress-iOS
: Enable gallery upload options in production wordpress-mobile/WordPress-iOS#13374Description
This PR enables gallery block upload options in production (on mobile).
How has this been tested?
To test: wordpress-mobile/gutenberg-mobile#1610 (comment)
Screenshots
Types of changes
Checklist: