Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix className attributes rendering for navigation/navigation link block #19996

Closed
wants to merge 2 commits into from
Closed

Fix className attributes rendering for navigation/navigation link block #19996

wants to merge 2 commits into from

Conversation

costasovo
Copy link
Contributor

@costasovo costasovo commented Feb 2, 2020

Description

This PR addresses an issue described in #19858
Both blocks support setting additional class in block settings, but the className is not applied as it should be.

I've added rendering of attributes.className for navigation block in editor environment and I've added rendering of those attributes for navigation link in both editor and front end.

How has this been tested?

Manually. I added classes: navi-class, first-level-class, second-level-class in navigation and navigation link blocks. See the results in screenshots.

Rendering in the editor

Screenshot 2020-02-02 at 09 30 13

Rendering in page

Screenshot 2020-02-02 at 09 31 55

Types of changes

This PR contains only additions to rendered outputs.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@talldan talldan added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Feb 3, 2020
@earnjam
Copy link
Contributor

earnjam commented May 13, 2020

The underlying issue for this PR was resolved in #20076, so I'm going to close this one out.

@earnjam earnjam closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants