Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph block: remove min-height #19835

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Paragraph block: remove min-height #19835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
620da41
Paragraph block: remove min-height
ellatrix Jan 23, 2020
e254787
Use lineheight to set drop cap min height
ellatrix Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/paragraph/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function useDropCapMinimumHeight( isDropCap, deps ) {
getComputedStyle(
element,
'first-letter'
).height
).lineHeight
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the computed style of the first-letter pseudo element doesn't seem to work in Firefox. Instead it calculates the height of the paragraph, which would be 0 if there's only a floated drop cap element. Using the line height fixes the problem since it's never 0. It also works nicely when it does work for the pseudo element. Tested in Safari, Chrome, and Firefox.

);
} else if ( minimumHeight ) {
setMinimumHeight( undefined );
Expand Down
7 changes: 1 addition & 6 deletions packages/block-library/src/paragraph/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
.block-editor-block-list__block[data-type="core/paragraph"] p {
min-height: $empty-paragraph-height / 2;
line-height: $editor-line-height;
}

// Overwrite the inline style to make the height collapse when the paragraph editable gets focus.
.block-editor-block-list__block[data-type="core/paragraph"] .has-drop-cap:focus {
min-height: $empty-paragraph-height / 2 !important;
min-height: auto !important;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto works just as well here, to autoresize the paragraph if the drop cap disappears and the inline style needs to be overridden.

}