Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SelectControl example code synax highlight #19803

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Fix SelectControl example code synax highlight #19803

merged 1 commit into from
Mar 20, 2020

Conversation

ediamin
Copy link
Contributor

@ediamin ediamin commented Jan 22, 2020

Description

This PR add missing language identifier to SelectControl component's example usage code.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

earnjam
earnjam approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@earnjam earnjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ediamin !

@earnjam earnjam merged commit bee1bf9 into WordPress:master Mar 20, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earnjam earnjam earnjam approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ediamin @earnjam