RNMobile - Cover Block: First iteration #19722

geriux · 2020-01-17T14:39:46Z

Guntenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#1781

Description

iOS	Android

This is the first iteration of the Cover block including:

Select image from WP media library
Use focalPoint if set on web(no settings yet, just rendering the image accordingly)
Use overlay color if set on web (no settings yet, just rendering the color accordingly)
Add "minimum height in pixels" setting similar to Spacer height
Add "background opacity" setting again similar to Spacer height using slider

For the focal point implementation, I created a new component ImageWithFocalPoint which allows passing the coordinates and setting the image in the right position depending on its container size.

The default text color was an issue for InnerBlocks because we don't have a system to inherit styles from parents. Our current default color is a darker one, the default text color on Web for any block within a Cover block is white. So I did this approach but I'm not sure if its the best one, any suggestions would be appreciated. The idea is to set a default text color for the parent block in this case Cover then the RichText component will check if there are styles set by its block parent. If not it will use the color from the style prop or as last option the default color.

I added a new prop __experimentalOnlyMediaLibrary for MediaPlaceholder and MediaUpload to show only the Media Library option while we develop the rest implementation of the Cover block.

Updated the Paragraph and Heading blocks to use __experimentalUseColors and to add some missing props.

Screenshots

Different Cover Blocks	Add Cover Block Placeholder

Select Media	Cover Block Settings

How has this been tested?

User case 1

Open the app with metro running
Add a Cover block
Tap on Add Image
Expect: To see only the option WordPress Media library
Select an image.
Expect: Image to be visible in the block
Add a text
Tap on the settings icon of the block
Expect: Two options to be shown: Minimum Height in pixels and Background Opacity
Play with those settings and check they work correctly.

User case 2

Go to the Web version of the editor and create a post with a Cover block
Select an image for the block
Decrease the height of the block and use the Focal point picker in the right sidebar, select any point.
Change the text color of your block
Save the post
Open the app with metro running
Open the newly created post
Expect: The Cover block to be visible, with the image, focal point, and text color selected.

User case 3

Go to the Web version of the editor and create a post with a Cover block
Select a custom solid background color for the block (not gradients)
Add a Heading block within the Cover block
Save the post
Open the app with metro running
Open the newly created post
Expect: The Cover block to be visible, with the Heading block inside the block.

User case 4

Go to the Web version of the editor and create a post with a Cover block
Select an image for the background
Type a text
Clear the media in the Media Settings box
Save the post
Open the app with metro running
Open the newly created post
Expect: The place holder of the Cover block to be visible (since we removed the background image), respecting the styles (margins, paddings, etc)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR. .

…seColors

koke · 2020-01-28T12:27:42Z

packages/components/src/mobile/image-with-focalpoint/index.native.js

+/**
+ * External dependencies
+ */
+import React from 'react';


We don't import React directly. I think everything you might need from React should be available in @wordpress/element instead

Thanks! Updated it to use @wordpress/element instead =)

chipsnyder · 2020-01-28T21:39:10Z

Hey @geriux, testing on Android worked well for me.

I did notice one thing that was inconsistent between web and mobile, but I'm not sure of the desired behavior or scope.

In mobile, I can set Minimum Height in pixels to be less than the height of the child elements. On the web, it will resize to prevent this setting. Is this in scope for this PR, or is that more for later tweaks?

Mobile (Android)	Web

…/cover-block

geriux · 2020-01-29T08:37:12Z

Hey @geriux, testing on Android worked well for me.

I did notice one thing that was inconsistent between web and mobile, but I'm not sure of the desired behavior or scope.

In mobile, I can set Minimum Height in pixels to be less than the height of the child elements. On the web, it will resize to prevent this setting. Is this in scope for this PR, or is that more for later tweaks?

Thanks for testing @chipsnyder! I'll have a look at that issue, we should prevent that as the web does.

…if the content has higher height

geriux · 2020-01-29T10:18:24Z

In mobile, I can set Minimum Height in pixels to be less than the height of the child elements. On the web, it will resize to prevent this setting. Is this in scope for this PR, or is that more for later tweaks?

@chipsnyder Updated the code and now it should be working as the Web. Let me know, thanks!

chipsnyder

Looks good @geriux!

koke · 2020-01-31T10:53:58Z

packages/block-library/src/cover/edit.js

@@ -156,7 +156,7 @@ function ResizableCover( {
 	);
 }

-function onCoverSelectMedia( setAttributes ) {
+export function onCoverSelectMedia( setAttributes ) {


I think this is OK, but I'm wondering if it'd be better to extract this logic to a shared utils file instead, and have a attributesFromMedia function there.

I think it is better to extract it, especially since the web file is kinda big already. a4dfbdd thanks for the name suggestion!

koke · 2020-01-31T10:58:44Z

packages/block-library/src/cover/edit.native.js

+const INNER_BLOCKS_TEMPLATE = [
+	[ 'core/paragraph', {
+		align: 'center',
+		fontSize: 'large',


I'm a bit concerned about this, since we still can't render or change font sizes from the app. This might lead to the user publishing something quite different from what they're seeing on mobile. This is specially worse if they add more than one paragraph, since the first one will be large by default and the second won't, but they would look the same inside the app.

Oh I didn't think about that 😱 good catch! For now, I'm removing setting the attribute as default until we support font sizes 5305373

koke · 2020-01-31T11:40:42Z

packages/block-library/src/cover/edit.native.js

+		}
+
+		if ( url ) {
+			return dimRatio !== 0 ? dimRatio / 100 : 0;


Interesting, how is this different than just doing return dimRatio / 100?

I seriously can't recall why I did this 😆 but yeah no need for that, updated it here e06c903 (sorry this commit has more changes due to prettier formatting)

koke · 2020-01-31T11:41:53Z

packages/block-library/src/cover/edit.native.js

+			return dimRatio !== 0 ? dimRatio / 100 : 0;
+		}
+
+		return url ? 0.5 : 1;


There's an if ( url ) with a return above this, so this would always return 1?

Yup no need for this, updated it e06c903#diff-b17d53802519ed746057fb2ee4a915edR111

koke · 2020-01-31T11:49:44Z

packages/components/src/mobile/image-with-focalpoint/index.native.js

+
+const ImageWithFocalPoint = ( {
+	containerSize,
+	contentHeight,


If I remember correctly from previous experiments, you can make the image fill the container with absolute positioning without knowing the exact container dimensions in code. We would still have to listen to layout events and get the exact dimensions to calculate offset, but it might be better to keep that logic inside this component than passing dimensions from the outside.

Definitely better to have the logic within the component, simpler to just pass the url and focalPoint and let the component handle the rest 🙌 e71ee48

koke · 2020-01-31T11:57:24Z

I'm running into this when trying to open the cover settings:

Not sure if it's specific to these changes, since I'm also seeing it for the spacer block settings.

…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/components/src/index.native.js

… solid background

geriux · 2020-02-14T13:08:31Z

Thanks for making me a test build! I had a chance to give it a proper run through it all, and have some feedback. Bear with me 😄 I broke the items down into what I would consider parts of this iteration (now), next iteration (next), and unrelated.

Thank you for the feedback!

“Add block here” indicator shouldn’t be shown after block is added (example: https://cloudup.com/cq4UynkRRze)

This looks like is a bug that we have in develop, I'll look if there's an opened issue if not I'll open one, thanks for spotting that!

I noticed you can’t replace background image. We could allow 1) long-press on the background to show edit/replace options and 2) a replace button in the block toolbar

I added both options =)

If a cover created on the web doesn’t have a background (of any type), InnerBlocks aren't shown (for example, if a cover has a paragraph block within it, but no bg) and it’s shown as a placeholder state: https://cloudup.com/c_3fU1yA9Tb)

Good catch! This case was when selecting a color from the theme. Now It will show a black color until we have support for that unless you have another color in mind =)

Some placeholder backgrounds overflow the container (example: https://cloudup.com/chk3cp8Gfrx)

This was related to the previous point, it is fixed now.

Unrelated

[Floating toolbar] Tapping on the parent block’s icon in the floating toolbar should select the parent

I'll investigate this since I tried it in the Media & Text block and it isn't working either.

Border, text colors can easily get lost depending on background/image. This will be addressed as part of a wider upcoming color system project

Sounds good!

iamthomasbishop · 2020-02-15T18:39:07Z

This looks like is a bug that we have in develop, I'll look if there's an opened issue if not I'll open one, thanks for spotting that!

Awesome! Thank you.

I added both options =)

👍

Good catch! This case was when selecting a color from the theme. Now It will show a black color until we have support for that unless you have another color in mind =)

Ahh, that’s right, I hadn’t thought about the theme-color thing affecting this. Perhaps for now we should use the same dark gray color as the placeholder BG.

I'll investigate this since I tried it in the Media & Text block and it isn't working either.

I should have been clearer in my messaging — this is something that we don’t need to worry about as it’s a separate issue. I think it’s a refinement that is either being addressed or will be in the near future 😀

Thank you, @geriux! This is really coming along nicely!

geriux · 2020-02-17T14:05:11Z

I also noticed the wrong placeholder icon color on dark mode:

Thanks for spotting this! Fixed by a61cbb6#diff-b17d53802519ed746057fb2ee4a915edR118

chipsnyder · 2020-02-17T14:19:41Z

I did some more testing with the latest changes and had a couple of observations and questions.

User Case 3
Retesting user case three I'm not seeing the solid color overlay any more

Android	Web

Cover with BG Color
If a cover created on the web only has a background color and no image it appears with the placeholder background. Not sure if that's a future iteration or not though

Android	Web

Some placeholder backgrounds overflow the container
Not sure where we landed on this, so just asking here. The Blocks with content seem to have internal padding where the placeholder doesn't. The similar coloring just made me think they should be the same size. Although I'm not sure what the desired state is for this.

geriux · 2020-02-17T18:08:14Z

Thanks for testing this again @chipsnyder !

Cover with BG Color
If a cover created on the web only has a background color and no image it appears with the placeholder background. Not sure if that's a future iteration or not though

Did you have the latest changes? I thought I fixed this and I can't reproduce it =(. Could you check if you had the latest commits? If you have, can you tell me the steps to reproduce?

Some placeholder backgrounds overflow the container
Not sure where we landed on this, so just asking here. The Blocks with content seem to have internal padding where the placeholder doesn't. The similar coloring just made me think they should be the same size. Although I'm not sure what the desired state is for this.

This should be fixed too (same as above)

Regarding the colors, I'll check again. I thought there were some default colors that we did support but it looks like that isn't working anymore. I'll let you know =)

For theme colors though, since we don't support those we will show the placeholder background until we add that feature.

chipsnyder · 2020-02-17T20:59:28Z

Hey @geriux, I was able to reproduce these, but I put my block config below and the steps. For the first one, I might just be using an unsupported color option.

When starting my metro server, I tried starting it with yarn start and yarn start:reset and got the same results.

Device: Pixel 3a API 29 (Physical Device)
Gutenberg 225e2bba9d8d809cd68d9b5c4882bd94e015ae7c
Gutenberg-Mobile db728c5e2a99a87a96fed44784831cd910c9700b
WordPress-Android 0519fcd9ace063660fd258c99b415c8986c2683b

Cover with BG Color
Block Config:

<!-- wp:cover {"overlayColor":"secondary"} -->
<div class="wp-block-cover has-secondary-background-color has-background-dim"><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…","fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size">Blank</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:cover -->

This block is using a color from the theme. I used the same color for user case 3, so it may be the same problem. Are we supporting theme colors yet?

The theme for my test site is Maywood.

Some placeholder backgrounds overflow the container

Block Config:

<!-- wp:cover -->
<div class="wp-block-cover has-background-dim"><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…","fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size">Dogs</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:cover -->

In Web:
1.) Add a Cover block
2.) Select an Image
3.) Type something in the Paragraph box
4.) Select Clear Media
5.) Save the draft (Or publish I've been using a draft page)

In Android:
1.) Load the page
See Cover block is overflowing.

…erblocks

geriux · 2020-02-18T14:43:25Z

Thanks for double checking @chipsnyder ! You had the latest changes and with your latest feedback, I was able to reproduce the issues =)

This block is using a color from the theme. I used the same color for user case 3, so it may be the same problem. Are we supporting theme colors yet?

Oh ok yeah not yet, only custom colors for this iteration (I'll update the test case)

Regarding the placeholder overflowing the margins, should be fixed with the latest commit 7a9341c 🙌

chipsnyder · 2020-02-20T16:49:35Z

✅User case 1
✅User case 2
✅User case 3
✅Replace the background via long press
✅Replace the background via the replace button
✅Blocks display as expected when partially set up:
- ✅No Image has text and a background-color
- ✅No Image has text and no background-color
- ✅Empty block added

I had one question on the link text in the paragraph block:

Add a new Cover block
Add an image
Select to add a link to the paragraph block
URL is filled with: redacted

If I preview the page and use that default link this is what that looks like

<!-- wp:cover {"url":"https://testeisbardev.files.wordpress.com/2020/02/img_20200218_1205361029976694387568552.jpg","id":120} -->
<div class="wp-block-cover has-background-dim" style="background-image:url(https://testeisbardev.files.wordpress.com/2020/02/img_20200218_1205361029976694387568552.jpg)"><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…"} -->
<p class="has-text-align-center">Nessie<a rel="noreferrer noopener" href="http://redacted" target="_blank">Hey</a></p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:cover -->

Editing thanks @geriux for letting me know about my mistake

geriux · 2020-02-20T17:57:03Z

I had one question on the link text in the paragraph block:

Add a new Cover block

Add an image

Select to add a link to the paragraph block

URL is filled with: redacted

If I preview the page and use that default link this is what that looks like

Thanks for testing! Glad to see those items are working correctly now =)

Regarding the links, there's an open issue related to it. Looks like it is not detecting links very well when it checks the clipboard.

koke

I left a comment around some code style, but it's not that important. Overall this looks great ✨

…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/block-library/src/index.native.js

geriux · 2020-02-24T12:28:32Z

Thank you all for the feedback! 🚀

github-actions · 2020-02-24T12:29:46Z

Size Change: +368 B (0%)

Total Size: 864 kB

Filename	Size	Change
`build/block-directory/index.js`	6.02 kB	-1 B
`build/block-library/index.js`	114 kB	+369 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`build/a11y/index.js`	1.01 kB	0 B
`build/annotations/index.js`	3.43 kB	0 B
`build/api-fetch/index.js`	3.39 kB	0 B
`build/autop/index.js`	2.58 kB	0 B
`build/blob/index.js`	620 B	0 B
`build/block-directory/style-rtl.css`	760 B	0 B
`build/block-directory/style.css`	760 B	0 B
`build/block-editor/index.js`	104 kB	0 B
`build/block-editor/style-rtl.css`	9.78 kB	0 B
`build/block-editor/style.css`	9.77 kB	0 B
`build/block-library/editor-rtl.css`	7.67 kB	0 B
`build/block-library/editor.css`	7.67 kB	0 B
`build/block-library/style-rtl.css`	7.49 kB	0 B
`build/block-library/style.css`	7.49 kB	0 B
`build/block-library/theme-rtl.css`	669 B	0 B
`build/block-library/theme.css`	671 B	0 B
`build/block-serialization-default-parser/index.js`	1.65 kB	0 B
`build/block-serialization-spec-parser/index.js`	3.1 kB	0 B
`build/blocks/index.js`	57.6 kB	0 B
`build/components/index.js`	190 kB	0 B
`build/components/style-rtl.css`	16.1 kB	0 B
`build/components/style.css`	16 kB	0 B
`build/compose/index.js`	5.76 kB	0 B
`build/core-data/index.js`	10.5 kB	0 B
`build/data-controls/index.js`	1.04 kB	0 B
`build/data/index.js`	8.22 kB	0 B
`build/date/index.js`	5.36 kB	0 B
`build/deprecated/index.js`	771 B	0 B
`build/dom-ready/index.js`	569 B	0 B
`build/dom/index.js`	3.06 kB	0 B
`build/edit-post/index.js`	90.7 kB	0 B
`build/edit-post/style-rtl.css`	8.7 kB	0 B
`build/edit-post/style.css`	8.69 kB	0 B
`build/edit-site/index.js`	4.58 kB	0 B
`build/edit-site/style-rtl.css`	2.77 kB	0 B
`build/edit-site/style.css`	2.76 kB	0 B
`build/edit-widgets/index.js`	4.36 kB	0 B
`build/edit-widgets/style-rtl.css`	2.8 kB	0 B
`build/edit-widgets/style.css`	2.79 kB	0 B
`build/editor/editor-styles-rtl.css`	327 B	0 B
`build/editor/editor-styles.css`	328 B	0 B
`build/editor/index.js`	45.1 kB	0 B
`build/editor/style-rtl.css`	4.13 kB	0 B
`build/editor/style.css`	4.11 kB	0 B
`build/element/index.js`	4.45 kB	0 B
`build/escape-html/index.js`	733 B	0 B
`build/format-library/index.js`	7.6 kB	0 B
`build/format-library/style-rtl.css`	500 B	0 B
`build/format-library/style.css`	501 B	0 B
`build/hooks/index.js`	1.92 kB	0 B
`build/html-entities/index.js`	621 B	0 B
`build/i18n/index.js`	3.45 kB	0 B
`build/is-shallow-equal/index.js`	711 B	0 B
`build/keyboard-shortcuts/index.js`	2.3 kB	0 B
`build/keycodes/index.js`	1.68 kB	0 B
`build/list-reusable-blocks/index.js`	2.99 kB	0 B
`build/list-reusable-blocks/style-rtl.css`	215 B	0 B
`build/list-reusable-blocks/style.css`	216 B	0 B
`build/media-utils/index.js`	4.85 kB	0 B
`build/notices/index.js`	1.57 kB	0 B
`build/nux/index.js`	3.02 kB	0 B
`build/nux/style-rtl.css`	616 B	0 B
`build/nux/style.css`	613 B	0 B
`build/plugins/index.js`	2.54 kB	0 B
`build/primitives/index.js`	1.49 kB	0 B
`build/priority-queue/index.js`	878 B	0 B
`build/redux-routine/index.js`	2.84 kB	0 B
`build/rich-text/index.js`	14.3 kB	0 B
`build/server-side-render/index.js`	2.54 kB	0 B
`build/shortcode/index.js`	1.7 kB	0 B
`build/token-list/index.js`	1.27 kB	0 B
`build/url/index.js`	4 kB	0 B
`build/viewport/index.js`	1.61 kB	0 B
`build/warning/index.js`	1.14 kB	0 B
`build/wordcount/index.js`	1.18 kB	0 B

_{compressed-size-action}

geriux · 2020-02-26T07:32:58Z

packages/block-library/src/paragraph/test/edit.native.js

@@ -12,6 +12,10 @@ import Paragraph from '../edit';
 * WordPress dependencies
 */
 jest.mock( '@wordpress/blocks' );
+jest.mock( '../../../../data/src/components/use-select', () => () => ( {


After some tests trying to mock this, using requireActual, etc. I wasn't able to make it work due to some exports issues.

We can't use @wordpress/data as the path due to the symlinks we have in Gutenberg Mobile

There were some tests in another mock here #19705 (comment) without any luck.

I'll keep an eye after this is merged to see how we can improve this.

RNMobile - Cover Block - First iteration

51f8935

geriux added the [Status] In Progress Tracking issues with work in progress label Jan 17, 2020

geriux changed the title ~~(WIP) RNMobile - Cover Block: First iteration~~ RNMobile - Cover Block: First iteration Jan 17, 2020

geriux mentioned this pull request Jan 17, 2020

Cover Block - First Iteration wordpress-mobile/gutenberg-mobile#1781

Merged

2 tasks

geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 17, 2020

Gerardo Pacheco added 6 commits January 22, 2020 11:04

Remove allowed blocks

c4bdb88

Fix content height

ac30632

Merge with master

e507dcd

RNMobile - Update Heading and Paragraph blocks to use __experimentalU…

970c666

…seColors

RNMobile - Cover block: import correct icon

419abf9

RNMobile - Cover block - Default color text for InnerBlocks

cd3baae

geriux removed the [Status] In Progress Tracking issues with work in progress label Jan 24, 2020

geriux marked this pull request as ready for review January 24, 2020 12:50

geriux requested review from ajitbohra, jorgefilipecosta, Soean and talldan as code owners January 24, 2020 12:50

Mock use select

7cee335

geriux requested a review from koke January 28, 2020 11:32

koke reviewed Jan 28, 2020

View reviewed changes

Merge branch 'master' of github.com:WordPress/gutenberg into rnmobile…

dcc1875

…/cover-block

RNMobile - Cover block - Use memo from element, don't set min height …

eb6fc3b

…if the content has higher height

chipsnyder approved these changes Jan 29, 2020

View reviewed changes

koke reviewed Jan 31, 2020

View reviewed changes

Gerardo Pacheco added 2 commits February 14, 2020 11:36

Merge branch 'master' of github.com:WordPress/gutenberg into rnmobile…

63767ef

…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/components/src/index.native.js

RNMobile - Cover block - Allow changing the image and fix blocks with…

4f7d25a

… solid background

RNMobile - Cover - Fallback for theme colors

225e2bb

RNMobile - Cover - Fix paddings for cover blocks with and without inn…

7a9341c

…erblocks

geriux requested review from koke and chipsnyder February 18, 2020 14:46

chipsnyder approved these changes Feb 20, 2020

View reviewed changes

koke approved these changes Feb 21, 2020

View reviewed changes

Gerardo Pacheco added 2 commits February 24, 2020 13:07

RNMobile - Cover - Overlay styles as a const instead of a function

ad28977

Merge branch 'master' of github.com:WordPress/gutenberg into rnmobile…

b4b9a68

…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/block-library/src/index.native.js

Gerardo Pacheco added 2 commits February 24, 2020 13:57

RNMobile - Cover block - Remove duplicated export

b343b2c

RNMobile - Paragraph - Test mock import

8bebf5e

geriux commented Feb 26, 2020

View reviewed changes

geriux merged commit 34fa8b2 into master Feb 26, 2020

github-actions bot added this to the Gutenberg 7.7 milestone Feb 26, 2020

Tug deleted the rnmobile/cover-block branch March 4, 2020 18:10

naiba4 mentioned this pull request Feb 7, 2024

[Snyk] Security upgrade appium from 2.0.0 to 2.5.0 naiba4/gutenberg#43

Open

MaxMood96 mentioned this pull request Feb 7, 2024

[Snyk] Security upgrade appium from 2.0.0 to 2.5.0 MaxMood96/gutenberg#142

Open

naiba4 mentioned this pull request Apr 22, 2024

[Snyk] Fix for 14 vulnerabilities naiba4/gutenberg#53

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RNMobile - Cover Block: First iteration #19722

RNMobile - Cover Block: First iteration #19722

geriux commented Jan 17, 2020 •

edited

Loading

koke Jan 28, 2020

geriux Jan 29, 2020

chipsnyder commented Jan 28, 2020

geriux commented Jan 29, 2020

geriux commented Jan 29, 2020

chipsnyder left a comment

koke Jan 31, 2020

geriux Feb 3, 2020

koke Jan 31, 2020

geriux Feb 3, 2020

koke Jan 31, 2020

geriux Feb 3, 2020

koke Jan 31, 2020

geriux Feb 3, 2020

koke Jan 31, 2020

geriux Feb 3, 2020

koke commented Jan 31, 2020

geriux commented Feb 14, 2020

Unrelated

iamthomasbishop commented Feb 15, 2020

geriux commented Feb 17, 2020 •

edited

Loading

chipsnyder commented Feb 17, 2020

geriux commented Feb 17, 2020

chipsnyder commented Feb 17, 2020

geriux commented Feb 18, 2020

chipsnyder commented Feb 20, 2020 •

edited

Loading

geriux commented Feb 20, 2020

koke left a comment

geriux commented Feb 24, 2020

github-actions bot commented Feb 24, 2020 •

edited

Loading

geriux Feb 26, 2020

RNMobile - Cover Block: First iteration #19722

RNMobile - Cover Block: First iteration #19722

Conversation

geriux commented Jan 17, 2020 • edited Loading

Description

Screenshots

How has this been tested?

User case 1

User case 2

User case 3

User case 4

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chipsnyder commented Jan 28, 2020

geriux commented Jan 29, 2020

geriux commented Jan 29, 2020

chipsnyder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koke commented Jan 31, 2020

geriux commented Feb 14, 2020

Unrelated

iamthomasbishop commented Feb 15, 2020

geriux commented Feb 17, 2020 • edited Loading

chipsnyder commented Feb 17, 2020

geriux commented Feb 17, 2020

chipsnyder commented Feb 17, 2020

geriux commented Feb 18, 2020

chipsnyder commented Feb 20, 2020 • edited Loading

geriux commented Feb 20, 2020

koke left a comment

Choose a reason for hiding this comment

geriux commented Feb 24, 2020

github-actions bot commented Feb 24, 2020 • edited Loading

Choose a reason for hiding this comment

geriux commented Jan 17, 2020 •

edited

Loading

geriux commented Feb 17, 2020 •

edited

Loading

chipsnyder commented Feb 20, 2020 •

edited

Loading

github-actions bot commented Feb 24, 2020 •

edited

Loading