Fix Navigation Link url escaping

[Addison-Stavlo]

Description

Fix for issue #19632 .

This PR updates the navigation-link component to pass the url through the escape function on saving a new link. Previously, a link such as http://example.com/?s=<> would lead to http://example.com/?s= when used on the front-end. Now, links saved with the url passed through the escape function will lead to the expected href on the front end.

How has this been tested?

Tested on local docker environment using links saved on the Navigation block.

Screenshots

In the editor

Saved without escape function

Saved with escape function

On the Front-End

Saved without escape function

Saved with escape function

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• [n/a] My code has proper inline documentation.
• [n/a] I've included developer documentation if appropriate.

[WunderBart]

Can we use native encodeURI instead of lodash's escape()?

A good related issue about it: https://stackoverflow.com/questions/75980/when-are-you-supposed-to-use-escape-instead-of-encodeuri-encodeuricomponent

[Addison-Stavlo]

Can we use native encodeURI instead of lodash's escape()?

Definitely! Thanks for linking that issue that is great to know. I have updated it to now use encodeURI instead of escape. Now, on the editor, the link looks a bit better too but still leads to the correct place on the front end.

With encodeURI function

[WunderBart]

Looks good!

[noahtallen]

I'll go ahead and merge this for you since everything is looking good!