Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-Author: Move HTML tags outside of the translatable string #19675

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Post-Author: Move HTML tags outside of the translatable string #19675

merged 1 commit into from
Jan 15, 2020

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Jan 15, 2020 •
edited
Loading

Description

Moves out HTML tag found in translatable string in block-library post-author.

See: https://github.com/WordPress/gutenberg/pull/19576/files#r366897189

How has this been tested?

Not tested currently.

Screenshots

Types of changes

PHP file changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@chriskmnds chriskmnds mentioned this pull request Jan 15, 2020
Merged
6 tasks
@Soean Soean merged commit 31396e6 into WordPress:master Jan 15, 2020
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
@chriskmnds chriskmnds mentioned this pull request Jan 21, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskmnds @epiqueras @Soean @ellatrix