Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: move keydown event to rootContainer #19575

Closed
wants to merge 1 commit into from
Closed

Block: move keydown event to rootContainer #19575

wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

Description

Continuation of #19397. This PR moves keydown event handler to the root container so it's only created once.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ellatrix
Copy link
Member Author

I'm actually not 100% sure about this change, so I'll close it for now.

@ellatrix ellatrix closed this Jan 11, 2020
@ellatrix ellatrix deleted the try/move-block-keydown branch January 11, 2020 01:24
@naiba4 naiba4 mentioned this pull request Jan 4, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ellatrix