Block Directory: Use the block's title for alt text on block directory plugin items. #19263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he block's icon when they are using an image file. Fixes: https://github.com/WordPress/gutenberg/pull/16524/files#r324268820
swissspidy
reviewed
Dec 20, 2019
packages/block-directory/src/components/downloadable-block-header/index.js
Show resolved
Hide resolved
MarcoZehe
approved these changes
Dec 23, 2019
packages/block-directory/src/components/downloadable-block-header/index.js
Show resolved
Hide resolved
StevenDufresne
deleted the
fix/block-directory-downloadable-block-header-img-alt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have a less than useful placeholder text ( 'block icon' ) for the icon that is associated to the block directory plugin. This PR grabs the blocks title, which cannot be blank, localizes it and adds it as the alt text.
This suggestion was spun out of a PR that was accepted and closed. See here:
https://github.com/WordPress/gutenberg/pull/16524/files#r324268820
Considerations:
I considered removing the alt tag altogether but this image feels more like content than something ornamental. (ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/)
How has this been tested?
The only applicable test is to inspect the
<img>tag and locate thealtattribute.Screenshots
None
Types of changes
Bug fix
Checklist: