Gallery block / media-placeholder - Preserve changes made while upload in progress.#19134

Merged

Addison-Stavlo merged 25 commits intoWordPress:masterfrom Addison-Stavlo:fix/gallery-block-remove-image-while-uploading-another

May 8, 2020

+41-6

Commits on May 7, 2020

added optional prop to pass by reference instead of value

Addison-Stavlo
authored and
jorgefilipecosta
committed
currentValue updated on adding/removing

Addison-Stavlo
authored and
jorgefilipecosta
committed
comment update

Addison-Stavlo
authored and
jorgefilipecosta
committed
fixed multiple upload bug

Addison-Stavlo
authored and
jorgefilipecosta
committed
removed stuff for trying to keep loaders that werent part of the upload group

Addison-Stavlo
authored and
jorgefilipecosta
committed
updates comments and naming

Addison-Stavlo
authored and
jorgefilipecosta
committed
updated galleryValue to fallback to empty array

Addison-Stavlo
authored and
jorgefilipecosta
committed
renamed values to be more semantic

Addison-Stavlo
authored and
jorgefilipecosta
committed
removed dynamicAlteration prop

Addison-Stavlo
authored and
jorgefilipecosta
committed
refactored to compare last pass of newMedia

Addison-Stavlo
authored and
jorgefilipecosta
committed
added comments, changed variable name

Addison-Stavlo
authored and
jorgefilipecosta
committed
simplified setting lastMediaPassed

Addison-Stavlo
authored and
jorgefilipecosta
committed
compare via includes instead

Addison-Stavlo
authored and
jorgefilipecosta
committed
added id check as first priority in filter

Addison-Stavlo
authored and
jorgefilipecosta
committed
edited comments

Addison-Stavlo
authored and
jorgefilipecosta
committed
rebased

Addison-Stavlo
authored and
jorgefilipecosta
committed
changed to soft equal for int/string ID comparison

Addison-Stavlo
authored and
jorgefilipecosta
committed
added unchanging reference for image array

Addison-Stavlo
authored and
jorgefilipecosta
committed
re-added fallback value for currentMedia, fixed linter == problem

Addison-Stavlo
authored and
jorgefilipecosta
committed
updated comment

Addison-Stavlo
authored and
jorgefilipecosta
committed
re-added addToGallery check, forced 'true' for our gallery

Addison-Stavlo
authored and
jorgefilipecosta
committed
refactored to use a getValue instead

Addison-Stavlo
authored and
jorgefilipecosta
committed
updated comment

Addison-Stavlo
authored and
jorgefilipecosta
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gallery block / media-placeholder - Preserve changes made while upload in progress.#19134

Commits on May 7, 2020

added optional prop to pass by reference instead of value

currentValue updated on adding/removing

comment update

fixed multiple upload bug

removed stuff for trying to keep loaders that werent part of the upload group

updates comments and naming

updated galleryValue to fallback to empty array

renamed values to be more semantic

removed dynamicAlteration prop

refactored to compare last pass of newMedia

added comments, changed variable name

simplified setting lastMediaPassed

compare via includes instead

added id check as first priority in filter

edited comments

rebased

changed to soft equal for int/string ID comparison

added unchanging reference for image array

re-added fallback value for currentMedia, fixed linter == problem

updated comment

re-added addToGallery check, forced 'true' for our gallery

refactored to use a getValue instead

updated comment

Commits on May 8, 2020

Remove getValue and use a reference to this.props.value

comment update