Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Merge mobile release v1.19.0 back into master #19047

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[RNMobile] Merge mobile release v1.19.0 back into master #19047

merged 1 commit into from
Dec 13, 2019

Conversation

cameronvoell
Copy link
Member

Description

Related PR in gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1667

Details:

How has this been tested?

This should be tested in this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1667 and in the WP apps directly (WPAndroid - wordpress-mobile/WordPress-Android#10926, WPiOS - wordpress-mobile/WordPress-iOS#13065.

Types of changes

No new changes, everything was introduced in separate PRs already.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@cameronvoell cameronvoell added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 10, 2019
@cameronvoell cameronvoell mentioned this pull request Dec 10, 2019
Merged
@hypest hypest requested a review from mchowning December 13, 2019 07:51
mchowning
mchowning approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good. :shipit:

@cameronvoell cameronvoell merged commit 1d1eb4f into master Dec 13, 2019
@cameronvoell cameronvoell deleted the rnmobile/release-v1.19.0 branch December 13, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronvoell @mchowning @mkevins