Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package: Replace fs-extra with rimraf. #18790

Merged
merged 1 commit into from
Nov 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bin/commander.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ const program = require( 'commander' );
const inquirer = require( 'inquirer' );
const semver = require( 'semver' );
const chalk = require( 'chalk' );
const fs = require( 'fs-extra' );
const fs = require( 'fs' );
const rimraf = require( 'rimraf' );
const SimpleGit = require( 'simple-git/promise' );
const childProcess = require( 'child_process' );
const Octokit = require( '@octokit/rest' );
Expand Down Expand Up @@ -243,8 +244,8 @@ async function updateThePluginStableVersion( version, abortMessage ) {
*/
async function runCleanLocalCloneStep( abortMessage ) {
await runStep( 'Cleaning the temporary folder', abortMessage, async () => {
await fs.remove( gitWorkingDirectoryPath );
await fs.remove( svnWorkingDirectoryPath );
await rimraf( gitWorkingDirectoryPath );
await rimraf( svnWorkingDirectoryPath );
} );
}

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@
"eslint-plugin-import": "2.18.2",
"fast-glob": "2.2.7",
"fbjs": "0.8.17",
"fs-extra": "8.0.1",
"glob": "7.1.2",
"husky": "3.0.5",
"inquirer": "6.3.1",
Expand Down