Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on mobile when pasting formatted text. #18740

Closed
wants to merge 1 commit into from
Closed

Fix crash on mobile when pasting formatted text. #18740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/blocks/src/api/raw-handling/html-formatting-remover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function( node ) {
}

// Ignore pre content.
if ( node.parentElement.closest( 'pre' ) ) {
if ( node.parentElement.closest && node.parentElement.closest( 'pre' ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is node.parentElement if not an element node or null? Could you add a test case or leave a comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellatrix - Do you mean a comment explaining the reason?
For what I understand, this check prevents a crash on Native Android. Would that be good for a comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to know the cause of the crash. What is node.parentElement, if not an Element? This line important for paste. We don't want it to be skipped, even for mobile.

https://developer.mozilla.org/en-US/docs/Web/API/Element/closest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this new PR that we hope will solve the root cause:
wordpress-mobile/gutenberg-mobile#1626

If that's the case, this PR won't be needed anymore 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

return;
}

Expand Down