Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rnmobile] Fix crash which occurs after deleting Image/Page break block #18527

Closed

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Nov 14, 2019

Fixes: wordpress-mobile/WordPress-Android#10491

How has this been tested?

Steps to repro - Case A

  • Create a new post
  • Click on the empty paragraph block
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Boom

Steps to repro - Case B

  • Create a new post
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • This time the block is removed without a crash
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Boom

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@marecar3 marecar3 added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 14, 2019
@marecar3 marecar3 self-assigned this Nov 14, 2019
@marecar3 marecar3 changed the title Add label native to Platform element when Platform is android or ios [rnmobile] Release 1.16.2 Nov 14, 2019
@marecar3 marecar3 mentioned this pull request Nov 14, 2019
6 tasks
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine.

@marecar3 marecar3 changed the title [rnmobile] Release 1.16.2 [rnmobile] Fix crash which occurs after deleting Image/Page break block Nov 15, 2019
@marecar3
Copy link
Contributor Author

Closing in favor of #18539

@marecar3 marecar3 closed this Nov 15, 2019
@marecar3 marecar3 deleted the rnmobile/release-1.16.2_from_tag branch November 15, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants