-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Navigation Menu Item" to "Link". #18422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of making the nomenclature consistent with what a user would expect rather than thinking about this technically as a "child Block of the Nav Menu Block" (which is developer-centric).
Question: is it always the case that the "item" is a link? Or am I splitting hairs here? Could we not have nav items which aren't actually linked and therefore do not technically constitute "links"?
Looks like this will need a rebase now. @mtias Do you consider this Blocking and do you want someone to take this over for you or will you continue? |
Yes, we should settle on names here before switching the experimental flag off. |
eec040f
to
ba15e66
Compare
Seems to me that we should not assume an item within the Navigation block will be a link. It’s a fairly common (even if not recommended) pattern to use a non-link item to create a group within a Navigation. To me, “Menu Item” seems obvious. |
A non-link item should likely be a different block — paragraph, heading, etc. |
So the idea to render in the front-end an item which doesn't have defined a link with an We need to re-define the behavior and workflow for the nav menu. Wondering for instance how to switch between the Nav Item to another block (paragraph, heading, etc) according to whether the item has defined a link or not. |
How would you add a different block? We don’t show the block inserter anymore, we just add the menu item block. As @retrofox mentions, I guess we could do some magic to change the block depending on if it has a link, but that seems very opaque and confusing. |
2f773d5
to
9726170
Compare
For now the navigation only allows one type of inner block, so there's no need for a selector. Once support for other types of blocks gets added, I'd anticipate the selector to come back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should cover it! Next up: core/navigation-menu
=> core/navigation
.
ca3be18
to
2a42582
Compare
2a42582
to
11b2967
Compare
Closes #18521
Revise how we name and refer to navigation items in different places.