link-control: implement onEdit mode #18225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Type] Enhancement
retrofox
requested review from
ellatrix,
talldan and
youknowriad
as code owners
|
Related comment #18062 (comment) |
|
Adding another issue reference #18135 |
getdave
requested changes
Nov 5, 2019
getdave
approved these changes
Nov 5, 2019
|
@retrofox Actually just realised you need to update the |
aduth
reviewed
Jan 17, 2020
Comment on lines
+95
to
+99
| // Populate input searcher whether | ||
| // the current link has a title. | ||
| if ( currentLink && currentLink.title ) { | ||
| setInputValue( currentLink.title ); | ||
| } |
There was a problem hiding this comment.
If we need this to be an "initializer" for the input value, couldn't we instead provide this as the initial value for the input state?
In other words, instead of:
Do:
const [ inputValue, setInputValue ] = useState( value.title );There was a problem hiding this comment.
It makes totally sense to me, Andrew. I don't exactly the reason why we added this initializer, especially because this component has been significantly refactored lately.
Going to help to review at your PR.
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It adds the idea of
editmode explicitly for the<LinkControl />component.Currently, this component changes its edit mode looking at the changes of
currentLinkproperty. This approach is used when it selects a new link from the link suggestions, and also when it clicks in the Change button.The tricky part comes when:
currentLink.titlevalueWe need to change the
currentLinkto trigger the edit mode, but at the same time, we want to keep thecurrentLinkvalue in order to populate the searcher input with its title.This PR set the edit mode explicitly and internally, populating the title if it's defined.
How has this been tested?
It has been tested in this PR: #18062.
ChangebuttonThe searcher input should be populated with the current link title.
Screenshots
Checklist: