-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Add Card Component #17963
Merged
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
ce0a22a
Add styled-components, hex-rgb, and storybook knobs
643d02f
Add styled-components and hex-rgb to wordpress/components dependencies
c867811
Implement Storybook knobs addon
93be05a
Add color utilities
90a1bcf
Create Card component + sub components, and add initial stories
66a869a
Export the new Card component
20fcdfd
Improve default, context, and prop merging for Card sub-components
3963db1
Refactor Card components + sub-components, and add tests
329218b
Fix typos in card test
45a1f31
Refactor Card stories
504169f
Add Card Header to export
6324887
Add README content for Card component
084a1e2
Add updated manifest-devhub.json autogenerated doc file
e93de65
Update Card README for context overrides
05f27c1
Merge branch 'master' into add/card-component
7441e2e
Remove unused fragment from Card stories
0ec36f1
Merge branch 'master' into add/card-component
96ff8bd
Update size prop values for Card components
4534ed4
Fix typo for Card docs
efe6ea8
Fix size values in storybook knob props
6ebe575
Simplify implementation of CardContext.Provider
bfde122
Remove duplicate addDecorator withKnobs
1d24ec9
Merge branch 'master' into add/card-component
a8bd44f
Remove prettier comment + fix size values in readme files
9876eba
Change `hex-rgb` dependency from `4.1.0` to `^4.1.0`
468097e
Revert "Change `hex-rgb` dependency from `4.1.0` to `^4.1.0`"
7df0507
Change `hex-rgb` dependency from `4.1.0` to `^4.1.0`
3378c86
Rename __utils.js file to _utils.js
599324e
Rename colors.values.js -> colors-values.js (hyphen)
287b48e
Refactor Card sub-components to use BEM classNames
1fe7528
Fix typo + description of size + variant in sub-component documentation
af39009
Merge branch 'master' into add/card-component
23fbe54
Add story example for horizontally aligned media
32ae38a
Use HorizontalRule primitive in CardDivider
3e596fd
Merge branch 'master' into add/card-component
9d26f28
Update Card component API
0cca7bc
Merge branch 'master' into add/card-component
b9f852d
Merge branch 'master' into add/card-component
4ae4dcb
Merge branch 'master' into add/card-component
344e8b0
Merge branch 'master' into add/card-component
bb54a62
Replace styled-components with emotion
f40a890
Change first-child -> first-of-type to resolve emotion warnings
ca8aad4
Fix @emotion dependencies for root package-lock.json
8559de5
Update dependencies in package-lock.json
ca80cd2
Merge branch 'master' into add/card-component
66b4421
Fixed babelrc
dbe16a2
Fix whitespacing (use tabs) for babelrc
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{ | ||
"presets": [ "@wordpress/babel-preset-default" ], | ||
"plugins": [ | ||
"babel-plugin-emotion", | ||
"babel-plugin-inline-json-import" | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: whitespaces, I don't think we lint this type of files :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! My bad. Fixing now. Thank you for catching <3