-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toolbars positionning in IE11 #17894
Conversation
Right off the bat it has a cost for non IE. This is Chrome: We have done some tricks in other code like this:
|
@jasmussen try to the image block instead (upload an image and check the toolbar) |
I can't test anymore because my virtualbox started crashing hard, so hard the mac reboots :( @jorgefilipecosta can you look? However as noted, the inline-flex rule breaks it for me in Chrome. You might want to do the "@supports" trick. |
Hi @youknowriad, I'm also noticing the problem @jasmussen referred to in other browsers.
If we remove and use inline-flex even on IE things start to work well in some blocks e.g: media & text but the toolbar of paragraphs starts breaking on IE. The fix you proposed seems an improvement on IE (there is only some unalignment) maybe we can target the fix for IE only? |
Yes, if we don't find anything better, we should do that. |
e3c1697
to
5e7c4c5
Compare
I only applied the fix to IE11, I think now it's decent in all browsers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR fixes a visual glitch in ie11 where toolbar segments in block toolbars appear one per line instead of part of the same "line".
I'm interested in testing this PR in other browsers to ensure there's no unwanted side-effect.
Testing instructions
Test block toolbars in Chrome/Firefox in several situations/alignments... and ensure it displays properly.