-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade #16937
Conversation
@@ -47,7 +47,7 @@ | |||
"jest-puppeteer": "^4.3.0", | |||
"minimist": "^1.2.0", | |||
"npm-package-json-lint": "^3.6.0", | |||
"puppeteer": "1.19.0", | |||
"puppeteer": "^1.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gziolo Just wanting to confirm that adding the ^
caret here is deliberate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, it enables ranged for puppeteer dependency so we could update it more often with ease.
Yes, I also included it in the CHANGELOG file. In general, while working on upgrade we started at 1.15 and didn't see any issues up to 1.19, so there is no need to be worried about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we keep these if there is a lock file? Why to get rid of all ^
entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not for us, it's for those who consume this package on npm. They shouldn't be forced to use the same version we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all makes sense, merge when green 💯
cbb8056
to
018456c
Compare
…#16937) * Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade * Scripts: Enable semver friendly updates to puppeteer dependency
…#16937) * Docs: Update CHANGELOG for @wordpress/scripts after Puppeteer upgrade * Scripts: Enable semver friendly updates to puppeteer dependency
Description
Follow-up for #16875.
This PR adds the missing CHANGELOG entries for
@wordpress/scripts
package.In addition, it enables ranged for
puppeteer
dependency so we could update it more often with ease.